Re: [msysGit] [PATCH/RFC 09/11] daemon: use run-command api for async serving

From: Johannes Sixt <j6t@kdbg.org>
To: kusmabite@gmail.com
Cc: msysgit@googlegroups.com, git@vger.kernel.org, dotzenlabs@gmail.com
Subject: Re: [msysGit] [PATCH/RFC 09/11] daemon: use run-command api for async  serving
Date: Wed, 2 Dec 2009 20:12:08 +0100	[thread overview]
Message-ID: <200912022012.08905.j6t@kdbg.org> (raw)
In-Reply-To: <40aa078e0912020745o4b72342fm722a944621cfda5@mail.gmail.com>

On Mittwoch, 2. Dezember 2009, Erik Faye-Lund wrote:
> On Fri, Nov 27, 2009 at 9:59 PM, Johannes Sixt <j6t@kdbg.org> wrote:
> > Would it make sense to
> > have a function finish_async_nowait() instead of is_async_alive() that
> > (1) stresses the start/finish symmetry and (2) can return more than just
> > Boolean?
>...
>
> I'm not entirely sure how to make the interface, though. Any good
> suggestions?

I suggest to model finish_async_nowait() after waitpid() so that

	while ((pid = waitpid(-1, &status, WNOHANG)) > 0) ...
becomes
	while ((pid = finish_async_nowait(&some_async, &status)) > 0) ...

but where the resulting status is already "decoded", i.e. zero is success and 
non-zero is failure (including death through signal); WIFEXITED and 
WEXITSTATUS should not be applicable to status anymore.

-- Hannes