From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756080AbZLCNnY (ORCPT ); Thu, 3 Dec 2009 08:43:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756040AbZLCNnX (ORCPT ); Thu, 3 Dec 2009 08:43:23 -0500 Received: from buzzloop.caiaq.de ([212.112.241.133]:55532 "EHLO buzzloop.caiaq.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755166AbZLCNnW (ORCPT ); Thu, 3 Dec 2009 08:43:22 -0500 Date: Thu, 3 Dec 2009 14:43:24 +0100 From: Daniel Mack To: Mark Brown Cc: linux-kernel@vger.kernel.org, Liam Girdwood , Pierre Ossman , Andrew Morton , Matt Fleming , Adrian Hunter , David Brownell , Russell King , Linus Walleij , Eric Miao , Robert Jarzmik , Cliff Brake , Jarkko Lavinen , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] mmc: move regulator handling to core Message-ID: <20091203134324.GB14091@buzzloop.caiaq.de> References: <1259844390-10541-1-git-send-email-daniel@caiaq.de> <20091203130627.GA31254@rakim.wolfsonmicro.main> <20091203131423.GV14091@buzzloop.caiaq.de> <20091203132241.GB31533@rakim.wolfsonmicro.main> <20091203133200.GX14091@buzzloop.caiaq.de> <20091203134031.GA1311@rakim.wolfsonmicro.main> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091203134031.GA1311@rakim.wolfsonmicro.main> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 03, 2009 at 01:40:32PM +0000, Mark Brown wrote: > On Thu, Dec 03, 2009 at 02:32:00PM +0100, Daniel Mack wrote: [...] > > The mmci people would need to answer that. To me, the code just looked > > like a power saving feature. > > > If this driver needs it, the only tweak to my patch to let that > > particular call site use regulator_get_exclusive, and the core will > > still do the right thing. For this case, the behaviour should be exactly > > the same than it currently is, correct? > > No, you'll also need to update the way the driver bootstraps the > reference count since with regulator_get_exclusive() the reference count > is initialised to 1 if the regulator is enabled when it is claimed. Ok, fine. It's still just the driver which would need amendment, not the core. Thanks for explaining this. Let's wait for the mmci maintainers to speak up on this particular point. Thanks, Daniel From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel@caiaq.de (Daniel Mack) Date: Thu, 3 Dec 2009 14:43:24 +0100 Subject: [PATCH] mmc: move regulator handling to core In-Reply-To: <20091203134031.GA1311@rakim.wolfsonmicro.main> References: <1259844390-10541-1-git-send-email-daniel@caiaq.de> <20091203130627.GA31254@rakim.wolfsonmicro.main> <20091203131423.GV14091@buzzloop.caiaq.de> <20091203132241.GB31533@rakim.wolfsonmicro.main> <20091203133200.GX14091@buzzloop.caiaq.de> <20091203134031.GA1311@rakim.wolfsonmicro.main> Message-ID: <20091203134324.GB14091@buzzloop.caiaq.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Dec 03, 2009 at 01:40:32PM +0000, Mark Brown wrote: > On Thu, Dec 03, 2009 at 02:32:00PM +0100, Daniel Mack wrote: [...] > > The mmci people would need to answer that. To me, the code just looked > > like a power saving feature. > > > If this driver needs it, the only tweak to my patch to let that > > particular call site use regulator_get_exclusive, and the core will > > still do the right thing. For this case, the behaviour should be exactly > > the same than it currently is, correct? > > No, you'll also need to update the way the driver bootstraps the > reference count since with regulator_get_exclusive() the reference count > is initialised to 1 if the regulator is enabled when it is claimed. Ok, fine. It's still just the driver which would need amendment, not the core. Thanks for explaining this. Let's wait for the mmci maintainers to speak up on this particular point. Thanks, Daniel