From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753707AbZLHKYC (ORCPT ); Tue, 8 Dec 2009 05:24:02 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753650AbZLHKYB (ORCPT ); Tue, 8 Dec 2009 05:24:01 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:40426 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753550AbZLHKXx (ORCPT ); Tue, 8 Dec 2009 05:23:53 -0500 Date: Tue, 8 Dec 2009 11:23:51 +0100 From: Pavel Machek To: Russell King - ARM Linux Cc: Ben Dooks , Brian Swetland , Arve Hj?nnev?g , kernel list , linux-arm-kernel Subject: Re: dream: glue for mmc controller Message-ID: <20091208102351.GG12264@elf.ucw.cz> References: <20091103105319.GA2492@elf.ucw.cz> <20091103105737.GE20341@fluff.org.uk> <20091108081314.GA16482@elf.ucw.cz> <20091108091009.GB20529@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091108091009.GB20529@n2100.arm.linux.org.uk> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 2009-11-08 09:10:10, Russell King - ARM Linux wrote: > On Sun, Nov 08, 2009 at 09:13:14AM +0100, Pavel Machek wrote: > > > > +#include > > > > +#include > > > linux/gpio.h > > > linux/io.h > > > > I got compile errors when trying to use linux/gpio.h: > > > > arch/arm/mach-msm/board-dream-gpio.c: In function > > 'dream_gpio_configure': > > arch/arm/mach-msm/board-dream-gpio.c:109: error: 'GPIOF_OUTPUT_LOW' > > undeclared (first use in this function) > > This means it's abusing the gpio header files - which are intended for > the generic GPIO support, but are being used for this platforms private > non-generic GPIO based stuff. Ok, will fix. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: pavel@ucw.cz (Pavel Machek) Date: Tue, 8 Dec 2009 11:23:51 +0100 Subject: dream: glue for mmc controller In-Reply-To: <20091108091009.GB20529@n2100.arm.linux.org.uk> References: <20091103105319.GA2492@elf.ucw.cz> <20091103105737.GE20341@fluff.org.uk> <20091108081314.GA16482@elf.ucw.cz> <20091108091009.GB20529@n2100.arm.linux.org.uk> Message-ID: <20091208102351.GG12264@elf.ucw.cz> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun 2009-11-08 09:10:10, Russell King - ARM Linux wrote: > On Sun, Nov 08, 2009 at 09:13:14AM +0100, Pavel Machek wrote: > > > > +#include > > > > +#include > > > linux/gpio.h > > > linux/io.h > > > > I got compile errors when trying to use linux/gpio.h: > > > > arch/arm/mach-msm/board-dream-gpio.c: In function > > 'dream_gpio_configure': > > arch/arm/mach-msm/board-dream-gpio.c:109: error: 'GPIOF_OUTPUT_LOW' > > undeclared (first use in this function) > > This means it's abusing the gpio header files - which are intended for > the generic GPIO support, but are being used for this platforms private > non-generic GPIO based stuff. Ok, will fix. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html