From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 3/5] arm: Flush TLB entries in setup_mm_for_reboot()
Date: Sat, 19 Dec 2009 09:06:07 +0000 [thread overview]
Message-ID: <20091219090607.GB28047@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20091219034619.26198.58992.stgit@localhost>
On Fri, Dec 18, 2009 at 07:46:19PM -0800, Tony Lindgren wrote:
> diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
> index 8c7fbd1..a2802ea 100644
> --- a/arch/arm/mm/mmu.c
> +++ b/arch/arm/mm/mmu.c
> @@ -1068,4 +1068,7 @@ void setup_mm_for_reboot(char mode)
> pmd[1] = __pmd(pmdval + (1 << (PGDIR_SHIFT - 1)));
> flush_pmd_entry(pmd);
> }
> +
> + local_flush_tlb_all();
> + flush_cache_all();
The cache flush is unnecessary. The caches should be off at this point.
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] arm: Flush TLB entries in setup_mm_for_reboot()
Date: Sat, 19 Dec 2009 09:06:07 +0000 [thread overview]
Message-ID: <20091219090607.GB28047@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20091219034619.26198.58992.stgit@localhost>
On Fri, Dec 18, 2009 at 07:46:19PM -0800, Tony Lindgren wrote:
> diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
> index 8c7fbd1..a2802ea 100644
> --- a/arch/arm/mm/mmu.c
> +++ b/arch/arm/mm/mmu.c
> @@ -1068,4 +1068,7 @@ void setup_mm_for_reboot(char mode)
> pmd[1] = __pmd(pmdval + (1 << (PGDIR_SHIFT - 1)));
> flush_pmd_entry(pmd);
> }
> +
> + local_flush_tlb_all();
> + flush_cache_all();
The cache flush is unnecessary. The caches should be off at this point.
next prev parent reply other threads:[~2009-12-19 9:06 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-19 3:45 [PATCH 0/5] V7/Cortex/omap34xx fixes for 2.6.33-rc1: DCC, kexec, atags Tony Lindgren
2009-12-19 3:45 ` Tony Lindgren
2009-12-19 3:45 ` [PATCH 1/5] arm: Fix DCC console for v7 Tony Lindgren
2009-12-19 3:45 ` Tony Lindgren
2009-12-19 3:46 ` [PATCH 2/5] arm: Fix cpu_proc_fin() for proc-v7.S and make kexec work Tony Lindgren
2009-12-19 3:46 ` Tony Lindgren
2009-12-19 3:46 ` [PATCH 3/5] arm: Flush TLB entries in setup_mm_for_reboot() Tony Lindgren
2009-12-19 3:46 ` Tony Lindgren
2009-12-19 9:06 ` Russell King - ARM Linux [this message]
2009-12-19 9:06 ` Russell King - ARM Linux
2009-12-19 17:54 ` Tony Lindgren
2009-12-19 17:54 ` Tony Lindgren
2009-12-19 18:10 ` Tony Lindgren
2009-12-19 18:10 ` Tony Lindgren
2009-12-19 3:46 ` [PATCH 4/5] arm: Fix init_atags_procfs() to check tag->hdr.size Tony Lindgren
2009-12-19 3:46 ` Tony Lindgren
2009-12-19 9:03 ` Russell King - ARM Linux
2009-12-19 9:03 ` Russell King - ARM Linux
2009-12-19 17:44 ` Tony Lindgren
2009-12-19 17:44 ` Tony Lindgren
2009-12-19 18:44 ` Tony Lindgren
2009-12-19 18:44 ` Tony Lindgren
2009-12-19 3:46 ` [PATCH 5/5] arm: Fix typo in cacheflush.h and remove unnecessary comments Tony Lindgren
2009-12-19 3:46 ` Tony Lindgren
2009-12-19 5:07 ` [PATCH 0/5] V7/Cortex/omap34xx fixes for 2.6.33-rc1: DCC, kexec, atags Tony Lindgren
2009-12-19 5:07 ` Tony Lindgren
2009-12-28 5:55 ` Magnus Damm
2009-12-28 5:55 ` Magnus Damm
2009-12-29 22:07 ` Tony Lindgren
2009-12-29 22:07 ` Tony Lindgren
2010-01-05 9:24 ` Magnus Damm
2010-01-05 9:24 ` Magnus Damm
2010-01-05 11:36 ` Mika Westerberg
2010-01-05 11:36 ` Mika Westerberg
2010-01-05 17:14 ` Tony Lindgren
2010-01-05 17:14 ` Tony Lindgren
2010-01-05 17:54 ` Paul Walmsley
2010-01-05 17:54 ` Paul Walmsley
2010-01-05 20:43 ` Tony Lindgren
2010-01-05 20:43 ` Tony Lindgren
2010-01-08 22:32 ` Woodruff, Richard
2010-01-08 22:32 ` Woodruff, Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091219090607.GB28047@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.