From: Sergey Sorokin <afarallax@yandex.ru>
To: Richard Henderson <rth@twiddle.net>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Alexander Graf <agraf@suse.de>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
Claudio Fontana <claudio.fontana@huawei.com>,
Vassili Karpov <av1474@comtv.ru>
Subject: Re: [Qemu-devel] [PATCH v2] Improve the alignment check infrastructure
Date: Thu, 23 Jun 2016 17:13:41 +0300 [thread overview]
Message-ID: <200981466691221@web14m.yandex.ru> (raw)
In-Reply-To: <458f40bb-cb58-4e10-2237-a08cb35155bd@twiddle.net>
A
A
23.06.2016, 17:05, "Richard Henderson" <rth@twiddle.net>:
On 06/23/2016 03:03 AM, Sergey Sorokin wrote:
A So what's wrong in this part of the patch?
I think I just misread it.
A
It happens :)
A
A
22.06.2016, 18:50, "Richard Henderson" <rth@twiddle.net>:
On 06/22/2016 05:37 AM, Sergey Sorokin wrote:
A +/* Use this mask to check interception with an alignment mask
A + * in a TCG backend.
A + */
A +#define TLB_FLAGS_MASK (TLB_INVALID_MASK | TLB_NOTDIRTY |
TLB_MMIO)
I think we ought to check this in tcg-op.c, rather than wait until
generating
code in the backend.
I think it's better to check this in one place in get_alignment_bits()
function
because there can be a direct call of helpers from softmmu_template.h.
next prev parent reply other threads:[~2016-06-23 14:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 12:37 [Qemu-devel] [PATCH v2] Improve the alignment check infrastructure Sergey Sorokin
2016-06-22 15:49 ` Richard Henderson
2016-06-22 16:30 ` Sergey Sorokin
2016-06-22 17:12 ` Richard Henderson
2016-06-23 10:03 ` Sergey Sorokin
2016-06-23 14:05 ` Richard Henderson
2016-06-23 14:13 ` Sergey Sorokin [this message]
2016-06-23 14:45 ` Sergey Sorokin
2016-06-23 16:12 ` Richard Henderson
2016-06-23 18:21 ` Sergey Sorokin
2016-06-23 19:06 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200981466691221@web14m.yandex.ru \
--to=afarallax@yandex.ru \
--cc=agraf@suse.de \
--cc=av1474@comtv.ru \
--cc=claudio.fontana@huawei.com \
--cc=crosthwaite.peter@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.