From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58685CA9EBB for ; Thu, 24 Oct 2019 09:47:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1FC8220856 for ; Thu, 24 Oct 2019 09:47:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="KBV53puN"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="LafDKB1y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731951AbfJXJrI (ORCPT ); Thu, 24 Oct 2019 05:47:08 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50358 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730343AbfJXJrI (ORCPT ); Thu, 24 Oct 2019 05:47:08 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 3265C60B67; Thu, 24 Oct 2019 09:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1571910427; bh=FgebyyM68KyCZTp8a5RynFQnhebEfIplee6uQIgAQqU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KBV53puNNObhltDnZ/11NInDZ5MHzlcguSGItDS6u5/x7v8Kb3e4l80f/ghQ6PqgZ PVAU1r8DmleRyrIzKCUN2MzeTMvjMcxT/Cxp0XjsNu5TQpiCPxO6Hkid99BTwDey/L TxBDi3eo0WUVpq/5rHLkiryFyGG1vrF70X17gI6E= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 063A060FEF; Thu, 24 Oct 2019 09:47:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1571910426; bh=FgebyyM68KyCZTp8a5RynFQnhebEfIplee6uQIgAQqU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LafDKB1y/2/61nQFjgpvN6qi8a3ZprsPjfuzsazfWp41f70tYiWXVJp962CFe+2M8 AyYVXTFUUfuRARtLhlBVjFUMG7kOyilWzBAV5fS7QsWFog42E5K5xctgtsodWgwVkm qie7thlh0PcWDcvslo/lQDWrOGH4zYdhWefCERKo= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 24 Oct 2019 17:47:05 +0800 From: Wen Gong To: Kalle Valo Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v6 2/3] ath10k: change max RX bundle size from 8 to 32 for sdio In-Reply-To: <87mudqsd6d.fsf@kamboji.qca.qualcomm.com> References: <1569402639-31720-1-git-send-email-wgong@codeaurora.org> <1569402639-31720-3-git-send-email-wgong@codeaurora.org> <87mudqsd6d.fsf@kamboji.qca.qualcomm.com> Message-ID: <200eef83925da532e49565bcf4f9ffc1@codeaurora.org> X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2019-10-24 17:30, Kalle Valo wrote: > Wen Gong writes: > >> The max bundle size support by firmware is 32, change it from 8 to 32 >> will help performance. This results in significant performance >> improvement on RX path. >> >> Tested with QCA6174 SDIO with firmware >> WLAN.RMH.4.4.1-00017-QCARMSWPZ-1 >> >> Signed-off-by: Wen Gong > > [...] > >> --- a/drivers/net/wireless/ath/ath10k/sdio.c >> +++ b/drivers/net/wireless/ath/ath10k/sdio.c >> @@ -24,7 +24,7 @@ >> #include "trace.h" >> #include "sdio.h" >> >> -#define ATH10K_SDIO_VSG_BUF_SIZE (32 * 1024) >> +#define ATH10K_SDIO_VSG_BUF_SIZE (64 * 1024) > > Is allocating 64 kb with kmalloc() reliable, especially on smaller > systems? I hope it is, but checking if someone else knows better. We > only do this only once in probe(), though. rx packet is more than 1500 bytes for performance test, so for 32 packets, 32*1024 is not enough. yes, it is allocated only one time for probe. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNZhz-0001wr-Sf for ath10k@lists.infradead.org; Thu, 24 Oct 2019 09:47:09 +0000 MIME-Version: 1.0 Date: Thu, 24 Oct 2019 17:47:05 +0800 From: Wen Gong Subject: Re: [PATCH v6 2/3] ath10k: change max RX bundle size from 8 to 32 for sdio In-Reply-To: <87mudqsd6d.fsf@kamboji.qca.qualcomm.com> References: <1569402639-31720-1-git-send-email-wgong@codeaurora.org> <1569402639-31720-3-git-send-email-wgong@codeaurora.org> <87mudqsd6d.fsf@kamboji.qca.qualcomm.com> Message-ID: <200eef83925da532e49565bcf4f9ffc1@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org On 2019-10-24 17:30, Kalle Valo wrote: > Wen Gong writes: > >> The max bundle size support by firmware is 32, change it from 8 to 32 >> will help performance. This results in significant performance >> improvement on RX path. >> >> Tested with QCA6174 SDIO with firmware >> WLAN.RMH.4.4.1-00017-QCARMSWPZ-1 >> >> Signed-off-by: Wen Gong > > [...] > >> --- a/drivers/net/wireless/ath/ath10k/sdio.c >> +++ b/drivers/net/wireless/ath/ath10k/sdio.c >> @@ -24,7 +24,7 @@ >> #include "trace.h" >> #include "sdio.h" >> >> -#define ATH10K_SDIO_VSG_BUF_SIZE (32 * 1024) >> +#define ATH10K_SDIO_VSG_BUF_SIZE (64 * 1024) > > Is allocating 64 kb with kmalloc() reliable, especially on smaller > systems? I hope it is, but checking if someone else knows better. We > only do this only once in probe(), though. rx packet is more than 1500 bytes for performance test, so for 32 packets, 32*1024 is not enough. yes, it is allocated only one time for probe. _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k