From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752770Ab0ALBnG (ORCPT ); Mon, 11 Jan 2010 20:43:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751264Ab0ALBnF (ORCPT ); Mon, 11 Jan 2010 20:43:05 -0500 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:51445 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890Ab0ALBnE (ORCPT ); Mon, 11 Jan 2010 20:43:04 -0500 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Tue, 12 Jan 2010 10:39:44 +0900 From: KAMEZAWA Hiroyuki To: Andi Kleen Cc: Wu Fengguang , "Zheng, Shaohui" , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "y-goto@jp.fujitsu.com" , Dave Hansen , "x86@kernel.org" Subject: Re: [PATCH - resend] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel(v1) Message-Id: <20100112103944.a9b1db76.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <4B4BD281.4080009@linux.intel.com> References: <20100108124851.GB6153@localhost> <20100111124303.GA21408@localhost> <20100112093031.0fc6877f.kamezawa.hiroyu@jp.fujitsu.com> <4B4BD281.4080009@linux.intel.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jan 2010 02:38:09 +0100 Andi Kleen wrote: > > > Hmmm....could you rewrite /dev/mem to use kernel/resource.c other than > > modifing e820 maps. ? > > Sorry but responding to bug fixes with "could you please rewrite ..." is > not considered fair. Shaohui is just trying to fix a bug here, not redesigning > a subsystem. > Quick hack for bug fix is okay to me. About this patch, I'm not sure whether we are allowed to rewrite e820map after boot. Thanks, -Kame From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with SMTP id 243106B006A for ; Mon, 11 Jan 2010 20:43:05 -0500 (EST) Received: from m5.gw.fujitsu.co.jp ([10.0.50.75]) by fgwmail5.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o0C1h2Es018991 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Tue, 12 Jan 2010 10:43:02 +0900 Received: from smail (m5 [127.0.0.1]) by outgoing.m5.gw.fujitsu.co.jp (Postfix) with ESMTP id 67A3C45DE4C for ; Tue, 12 Jan 2010 10:43:02 +0900 (JST) Received: from s5.gw.fujitsu.co.jp (s5.gw.fujitsu.co.jp [10.0.50.95]) by m5.gw.fujitsu.co.jp (Postfix) with ESMTP id 4833D45DE38 for ; Tue, 12 Jan 2010 10:43:02 +0900 (JST) Received: from s5.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s5.gw.fujitsu.co.jp (Postfix) with ESMTP id 331731DB8038 for ; Tue, 12 Jan 2010 10:43:02 +0900 (JST) Received: from m108.s.css.fujitsu.com (m108.s.css.fujitsu.com [10.249.87.108]) by s5.gw.fujitsu.co.jp (Postfix) with ESMTP id 910E1E18003 for ; Tue, 12 Jan 2010 10:42:58 +0900 (JST) Date: Tue, 12 Jan 2010 10:39:44 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH - resend] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel(v1) Message-Id: <20100112103944.a9b1db76.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <4B4BD281.4080009@linux.intel.com> References: <20100108124851.GB6153@localhost> <20100111124303.GA21408@localhost> <20100112093031.0fc6877f.kamezawa.hiroyu@jp.fujitsu.com> <4B4BD281.4080009@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Andi Kleen Cc: Wu Fengguang , "Zheng, Shaohui" , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "y-goto@jp.fujitsu.com" , Dave Hansen , "x86@kernel.org" List-ID: On Tue, 12 Jan 2010 02:38:09 +0100 Andi Kleen wrote: > > > Hmmm....could you rewrite /dev/mem to use kernel/resource.c other than > > modifing e820 maps. ? > > Sorry but responding to bug fixes with "could you please rewrite ..." is > not considered fair. Shaohui is just trying to fix a bug here, not redesigning > a subsystem. > Quick hack for bug fix is okay to me. About this patch, I'm not sure whether we are allowed to rewrite e820map after boot. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org