From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753436Ab0ALBxx (ORCPT ); Mon, 11 Jan 2010 20:53:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752883Ab0ALBxv (ORCPT ); Mon, 11 Jan 2010 20:53:51 -0500 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:49661 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751743Ab0ALBxu (ORCPT ); Mon, 11 Jan 2010 20:53:50 -0500 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Tue, 12 Jan 2010 10:50:12 +0900 From: KAMEZAWA Hiroyuki To: KAMEZAWA Hiroyuki Cc: Andi Kleen , Wu Fengguang , "Zheng, Shaohui" , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "y-goto@jp.fujitsu.com" , Dave Hansen , "x86@kernel.org" Subject: Re: [PATCH - resend] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel(v1) Message-Id: <20100112105012.4a210a1c.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20100112103944.a9b1db76.kamezawa.hiroyu@jp.fujitsu.com> References: <20100108124851.GB6153@localhost> <20100111124303.GA21408@localhost> <20100112093031.0fc6877f.kamezawa.hiroyu@jp.fujitsu.com> <4B4BD281.4080009@linux.intel.com> <20100112103944.a9b1db76.kamezawa.hiroyu@jp.fujitsu.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jan 2010 10:39:44 +0900 KAMEZAWA Hiroyuki wrote: > On Tue, 12 Jan 2010 02:38:09 +0100 > Andi Kleen wrote: > > > > > > Hmmm....could you rewrite /dev/mem to use kernel/resource.c other than > > > modifing e820 maps. ? > > > > Sorry but responding to bug fixes with "could you please rewrite ..." is > > not considered fair. Shaohui is just trying to fix a bug here, not redesigning > > a subsystem. > > > Quick hack for bug fix is okay to me. > Just an information. We already check kenerke/resource.c's resource information, here. read_mem() -> range_is_allowed() -> devmem_is_allowd() -> iomem_is_exclusive() extra calls of page_is_ram() to ask architecture's map seems redundunt. But, I know PPC guys doesn't use ioresource.c, hehe. Thanks, -Kame From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id BE8026B006A for ; Mon, 11 Jan 2010 20:53:43 -0500 (EST) Received: from m2.gw.fujitsu.co.jp ([10.0.50.72]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o0C1reQu026427 for (envelope-from kamezawa.hiroyu@jp.fujitsu.com); Tue, 12 Jan 2010 10:53:41 +0900 Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id A8BCF45DE62 for ; Tue, 12 Jan 2010 10:53:40 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 858F445DE55 for ; Tue, 12 Jan 2010 10:53:40 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 6B2E5E78004 for ; Tue, 12 Jan 2010 10:53:40 +0900 (JST) Received: from ml14.s.css.fujitsu.com (ml14.s.css.fujitsu.com [10.249.87.104]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 1C82E1DB8038 for ; Tue, 12 Jan 2010 10:53:40 +0900 (JST) Date: Tue, 12 Jan 2010 10:50:12 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH - resend] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel(v1) Message-Id: <20100112105012.4a210a1c.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20100112103944.a9b1db76.kamezawa.hiroyu@jp.fujitsu.com> References: <20100108124851.GB6153@localhost> <20100111124303.GA21408@localhost> <20100112093031.0fc6877f.kamezawa.hiroyu@jp.fujitsu.com> <4B4BD281.4080009@linux.intel.com> <20100112103944.a9b1db76.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: Andi Kleen , Wu Fengguang , "Zheng, Shaohui" , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "y-goto@jp.fujitsu.com" , Dave Hansen , "x86@kernel.org" List-ID: On Tue, 12 Jan 2010 10:39:44 +0900 KAMEZAWA Hiroyuki wrote: > On Tue, 12 Jan 2010 02:38:09 +0100 > Andi Kleen wrote: > > > > > > Hmmm....could you rewrite /dev/mem to use kernel/resource.c other than > > > modifing e820 maps. ? > > > > Sorry but responding to bug fixes with "could you please rewrite ..." is > > not considered fair. Shaohui is just trying to fix a bug here, not redesigning > > a subsystem. > > > Quick hack for bug fix is okay to me. > Just an information. We already check kenerke/resource.c's resource information, here. read_mem() -> range_is_allowed() -> devmem_is_allowd() -> iomem_is_exclusive() extra calls of page_is_ram() to ask architecture's map seems redundunt. But, I know PPC guys doesn't use ioresource.c, hehe. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org