From: David Brownell <david-b@pacbell.net>
To: Matt Mackall <mpm@selenic.com>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
David Woodhouse <dwmw2@infradead.org>,
Linux Mailing List <linux-kernel@vger.kernel.org>,
"linux-embedded" <linux-embedded@vger.kernel.org>
Subject: Re: flash_platform_data namespace collision
Date: Sat, 16 Jan 2010 11:23:15 -0800 [thread overview]
Message-ID: <201001161123.15502.david-b@pacbell.net> (raw)
In-Reply-To: <1263664079.29868.6289.camel@calx>
On Saturday 16 January 2010, Matt Mackall wrote:
> On Sat, 2010-01-16 at 11:04 +0000, Russell King wrote:
> > On Fri, Jan 15, 2010 at 11:41:15PM -0600, Matt Mackall wrote:
> > > I've got a board here with SPI, NOR, and NAND flash devices and I've
> > > just run into a namespace collision on flash_platform_data from
> >
> > The one in arch/arm/include/asm/mach/flash.h is designed to have great
> > appeal and flexibility across different platforms, and indeed we have
> > at least 70 users across six different MTD NOR flash drivers and two
> > MTD NAND drivers.
Yet it doesn't do what's needed for SPI flash (identify the chip type,
when it can't probed); and for that application none of those methods
are useful (and their slots are just wasted/confusing space).
> > If anything, I believe that this header should move into linux/mtd/
> > and become a standard structure for platforms to communicate their
> > requirements to flash drivers.
>
> Yeah, I think this is probably the way to go. Davids, any objections?
I had similar thoughts when I first happened across that structure.
But such a move wouldn't resolve $SUBJECT ... which is IMO best addressed
by the obvious rename of the one to spi_flash_platform_data.
- dave
prev parent reply other threads:[~2010-01-16 19:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-16 5:41 flash_platform_data namespace collision Matt Mackall
2010-01-16 6:03 ` David Brownell
2010-01-16 11:04 ` Russell King
2010-01-16 17:47 ` Matt Mackall
2010-01-16 19:23 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001161123.15502.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=dwmw2@infradead.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.