From: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3] Add push --set-upstream
Date: Sat, 16 Jan 2010 15:46:57 +0200 [thread overview]
Message-ID: <20100116134656.GA4504@Knoppix> (raw)
In-Reply-To: <20100116203557.95340c00.rctay89@gmail.com>
On Sat, Jan 16, 2010 at 08:35:57PM +0800, Tay Ray Chuan wrote:
> Hi,
>
> On Sat, 16 Jan 2010 11:23:47 +0200
> Ilari Liusvaara <ilari.liusvaara@elisanet.fi> wrote:
> > + OPT_BIT('u', "set-upstream", &flags, "Set upstream for git pull", TRANSPORT_PUSH_SET_UPSTREAM),
>
> This line exceeds 80 characters.
Broken into two (without breaking the message), it is still over 80.
> Also, I think you should follow the case-style of the other option
> descriptions and s/Set(?= upstream)/set/.
Fixed.
> > [snip]
> > +static void set_upstreams(struct transport *trans, struct ref *refs,
>
> I would prefer if you could follow the naming convention and say
> "transport" instead of truncating to "trans".
Fixed.
> > + struct ref *i;
> > + for (i = refs; i; i = i->next) {
>
> In most places, "ref" instead of "i" is used; ie.
Fixed.
> > + * alreay up-to-date ref create/modify (not delete).
>
> s/alreay/already/.
Fixed.
> > + /* Chase symbolic refs (mainly for HEAD). */
>
> Did you mean "Change" here?
No. Changed to 'Follow'.
> Regarding the checking of ref->status here:
>
> Is it possible to delegate this to push_had_errors(remote_refs)
> instead? We skip setting up upstream tracking when there are errors
> from pushing, so we don't have to check ref->status anymore.
No. As documetnation says, the update or no update is done on per-branch
basis.
<snip patch>
> (As a side note, if you apply this on top of 'tr/http-push-ref-status'
> in 'pu', the result of push_had_errors() is saved in a variable
> ('err'), so you could just use it and not have to call push_had_errors
> () again.)
See above.
I'll sit on v4 for some more time to wait for more comments.
-Ilari
next prev parent reply other threads:[~2010-01-16 14:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-16 9:23 [PATCH v3] Add push --set-upstream Ilari Liusvaara
2010-01-16 12:35 ` Tay Ray Chuan
2010-01-16 13:46 ` Ilari Liusvaara [this message]
2010-01-16 15:30 ` Tay Ray Chuan
2010-01-16 15:56 ` Ilari Liusvaara
2010-01-16 16:13 ` Tay Ray Chuan
2010-01-16 18:12 ` Tay Ray Chuan
2010-01-16 18:28 ` Jeff King
2010-01-16 18:39 ` Tay Ray Chuan
2010-01-16 16:47 ` Junio C Hamano
2010-01-16 18:43 ` Tay Ray Chuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100116134656.GA4504@Knoppix \
--to=ilari.liusvaara@elisanet.fi \
--cc=git@vger.kernel.org \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.