From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753850Ab0AZNSK (ORCPT ); Tue, 26 Jan 2010 08:18:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753502Ab0AZNSH (ORCPT ); Tue, 26 Jan 2010 08:18:07 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:57582 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398Ab0AZNSF (ORCPT ); Tue, 26 Jan 2010 08:18:05 -0500 Date: Tue, 26 Jan 2010 05:18:17 -0800 (PST) Message-Id: <20100126.051817.215651254.davem@davemloft.net> To: geert@linux-m68k.org Cc: adobriyan@gmail.com, linux-next@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: drivers/net/ariadne.c:165: error: 'set_multicast_list' undeclared here (not in a function) From: David Miller In-Reply-To: <10f740e81001260057h37f3494dvefa3a37b2e1453a5@mail.gmail.com> References: <10f740e81001260057h37f3494dvefa3a37b2e1453a5@mail.gmail.com> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Geert Uytterhoeven Date: Tue, 26 Jan 2010 09:57:05 +0100 > http://kisskb.ellerman.id.au/kisskb/buildresult/2076964/ > > drivers/net/ariadne.c:165: error: 'set_multicast_list' undeclared here > (not in a function) > > Seems to be broken by: I'll fix this with the patch below. Alexey, please go through at least drivers/net and look at the other stale references to these HAVE_* macros. For example I still see a bunch of HAVE_POLL_CONTROLLER stuff. Thanks. ariadne: Fix build. References removed HAVE_MULTICAST. Reporeted-by: Geert Uytterhoeven Signed-off-by: David S. Miller --- drivers/net/ariadne.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/ariadne.c b/drivers/net/ariadne.c index c35af3e..e2c2024 100644 --- a/drivers/net/ariadne.c +++ b/drivers/net/ariadne.c @@ -123,9 +123,7 @@ static void ariadne_reset(struct net_device *dev); static irqreturn_t ariadne_interrupt(int irq, void *data); static int ariadne_close(struct net_device *dev); static struct net_device_stats *ariadne_get_stats(struct net_device *dev); -#ifdef HAVE_MULTICAST static void set_multicast_list(struct net_device *dev); -#endif static void memcpyw(volatile u_short *dest, u_short *src, int len) -- 1.6.6.1