From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755182Ab0AZT3m (ORCPT ); Tue, 26 Jan 2010 14:29:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755089Ab0AZT3H (ORCPT ); Tue, 26 Jan 2010 14:29:07 -0500 Received: from kroah.org ([198.145.64.141]:33594 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754275Ab0AZT3C (ORCPT ); Tue, 26 Jan 2010 14:29:02 -0500 X-Mailbox-Line: From gregkh@mini.kroah.org Tue Jan 26 11:16:24 2010 Message-Id: <20100126191624.411026014@mini.kroah.org> User-Agent: quilt/0.48-1 Date: Tue, 26 Jan 2010 11:14:41 -0800 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: stable-review@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Dan Carpenter , Tyler Hicks Subject: [05/11] ecryptfs: use after free In-Reply-To: <20100126191730.GA20872@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2.6.27-stable review patch. If anyone has any objections, please let us know. ------------------ From: Dan Carpenter commit ece550f51ba175c14ec3ec047815927d7386ea1f upstream. The "full_alg_name" variable is used on a couple error paths, so we shouldn't free it until the end. Signed-off-by: Dan Carpenter Signed-off-by: Tyler Hicks Signed-off-by: Greg Kroah-Hartman --- fs/ecryptfs/crypto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/fs/ecryptfs/crypto.c +++ b/fs/ecryptfs/crypto.c @@ -1733,7 +1733,7 @@ ecryptfs_process_key_cipher(struct crypt char *cipher_name, size_t *key_size) { char dummy_key[ECRYPTFS_MAX_KEY_BYTES]; - char *full_alg_name; + char *full_alg_name = NULL; int rc; *key_tfm = NULL; @@ -1748,7 +1748,6 @@ ecryptfs_process_key_cipher(struct crypt if (rc) goto out; *key_tfm = crypto_alloc_blkcipher(full_alg_name, 0, CRYPTO_ALG_ASYNC); - kfree(full_alg_name); if (IS_ERR(*key_tfm)) { rc = PTR_ERR(*key_tfm); printk(KERN_ERR "Unable to allocate crypto cipher with name " @@ -1770,6 +1769,7 @@ ecryptfs_process_key_cipher(struct crypt goto out; } out: + kfree(full_alg_name); return rc; }