From: Gleb Natapov <gleb@redhat.com>
To: Wei Yongjun <yjwei@cn.fujitsu.com>
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] KVM: x86 emulator: code style cleanup
Date: Thu, 11 Feb 2010 12:00:28 +0200 [thread overview]
Message-ID: <20100211100028.GM2995@redhat.com> (raw)
In-Reply-To: <4B737587.3070301@cn.fujitsu.com>
On Thu, Feb 11, 2010 at 11:12:07AM +0800, Wei Yongjun wrote:
> Just remove redundant semicolon.
>
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
> ---
> arch/x86/kvm/emulate.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 31f4526..8a52616 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -1012,7 +1012,7 @@ done_prefixes:
> }
>
> if (mode == X86EMUL_MODE_PROT64 && (c->d & No64)) {
> - kvm_report_emulation_failure(ctxt->vcpu, "invalid x86/64 instruction");;
> + kvm_report_emulation_failure(ctxt->vcpu, "invalid x86/64 instruction");
> return -1;
> }
>
Shouldn't we inject #UD here?
--
Gleb.
next prev parent reply other threads:[~2010-02-11 10:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 3:12 [PATCH] KVM: x86 emulator: code style cleanup Wei Yongjun
2010-02-11 10:00 ` Gleb Natapov [this message]
2010-02-11 10:03 ` Avi Kivity
2010-02-11 10:06 ` Gleb Natapov
2010-02-11 10:07 ` Avi Kivity
2010-02-11 10:04 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100211100028.GM2995@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.