From: Jerome Glisse <glisse@freedesktop.org>
To: Maarten Maathuis <madman2003@gmail.com>
Cc: dri-devel@lists.sourceforge.net
Subject: Re: [PATCH 2/2] drm/radeon: Add asic hook for dma copy to r200 cards.
Date: Thu, 11 Feb 2010 12:51:08 +0100 [thread overview]
Message-ID: <20100211115108.GB2181@localhost.localdomain> (raw)
In-Reply-To: <6d4bc9fc1002101540i6f24b744vf9da81645bf34435@mail.gmail.com>
On Thu, Feb 11, 2010 at 12:40:45AM +0100, Maarten Maathuis wrote:
> What happens if you have two cards, one RS200 and one RV280 (just an
> example). I think you shouldn't change values in a static struct.
>
Yeah good catch, it's best to do a separate asic struct for r200 rather
than changing the static struct.
Cheers,
Jerome
------------------------------------------------------------------------------
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
--
next prev parent reply other threads:[~2010-02-11 11:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 22:10 [PATCH 1/2] drm/radeon: Skip dma copy test in benchmark if card doesn't have dma engine Pauli Nieminen
2010-02-10 22:10 ` [PATCH 2/2] drm/radeon: Add asic hook for dma copy to r200 cards Pauli Nieminen
2010-02-10 23:40 ` Maarten Maathuis
2010-02-11 11:51 ` Jerome Glisse [this message]
2010-02-11 15:08 ` Alex Deucher
2010-02-11 17:55 ` [PATCH] drm/radeon/kms: Create asic structure for r300 pcie cards Pauli Nieminen
2010-02-18 4:49 ` Dave Airlie
2010-02-11 17:25 ` [PATCH 2/2] drm/radeon: Add asic hook for dma copy to r200 cards Pauli Nieminen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100211115108.GB2181@localhost.localdomain \
--to=glisse@freedesktop.org \
--cc=dri-devel@lists.sourceforge.net \
--cc=madman2003@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.