From: Oleg Nesterov <oleg@redhat.com>
To: Roland McGrath <roland@redhat.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
hjl.tools@gmail.com, peter.lachner@intel.com
Subject: Re: [patch v3 2/2] ptrace: Add support for generic PTRACE_GETREGSET/PTRACE_SETREGSET
Date: Fri, 12 Feb 2010 16:59:55 +0100 [thread overview]
Message-ID: <20100212155955.GA16870@redhat.com> (raw)
In-Reply-To: <20100212035606.119B3C821@magilla.sf.frob.com>
On 02/11, Roland McGrath wrote:
>
> > +static int ptrace_regset(struct task_struct *task, int req, unsigned int type,
> > + struct iovec *kiov)
> > +{
> > + const struct user_regset_view *view = task_user_regset_view(task);
> > + const struct user_regset *regset = find_regset(view, type);
> > + int regset_no;
> > +
> > + if (!regset || (kiov->iov_len % regset->size) != 0)
> > + return -EIO;
>
> My inclination would be to diagnose these more specifically.
Agreed.
Otherwise I think the patch is fine.
Oleg.
prev parent reply other threads:[~2010-02-12 16:00 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 19:50 [patch v3 0/2] updated ptrace/core-dump patches for supporting xstate - v3 Suresh Siddha
2010-02-11 19:50 ` [patch v3 1/2] x86, ptrace: regset extensions to support xstate Suresh Siddha
2010-02-11 23:18 ` [tip:x86/ptrace] " tip-bot for Suresh Siddha
2010-02-12 3:45 ` [patch v3 1/2] " Roland McGrath
2010-02-12 17:31 ` Oleg Nesterov
2010-02-11 19:51 ` [patch v3 2/2] ptrace: Add support for generic PTRACE_GETREGSET/PTRACE_SETREGSET Suresh Siddha
2010-02-11 23:19 ` [tip:x86/ptrace] " tip-bot for Suresh Siddha
2010-02-22 9:07 ` Ingo Molnar
2010-02-22 9:33 ` linux-next requiements (Was: Re: [tip:x86/ptrace] ptrace: Add support for generic PTRACE_GETREGSET/PTRACE_SETREGSET) Stephen Rothwell
2010-02-22 10:27 ` Ingo Molnar
2010-02-22 11:47 ` linux-next requirements " Stephen Rothwell
2010-02-22 22:57 ` H. Peter Anvin
2010-02-22 23:59 ` Stephen Rothwell
2010-02-23 20:20 ` Roland McGrath
2010-02-23 20:49 ` H. Peter Anvin
2010-02-23 22:54 ` Stephen Rothwell
2010-02-23 8:45 ` Ingo Molnar
2010-02-23 19:52 ` Al Viro
2010-02-23 19:57 ` Al Viro
2010-02-24 7:25 ` linux-next requirements Stephen Rothwell
2010-02-27 1:53 ` Grant Likely
2010-02-27 8:53 ` Geert Uytterhoeven
2010-02-27 9:09 ` Jaswinder Singh Rajput
2010-02-27 9:39 ` Ingo Molnar
2010-02-27 12:23 ` Rafael J. Wysocki
2010-02-27 12:47 ` Ingo Molnar
2010-02-27 19:07 ` Rafael J. Wysocki
2010-02-27 21:50 ` Geert Uytterhoeven
2010-02-27 22:31 ` Rafael J. Wysocki
2010-02-28 7:06 ` Ingo Molnar
2010-02-28 12:22 ` Rafael J. Wysocki
2010-02-28 7:14 ` Ingo Molnar
2010-02-28 7:37 ` Stephen Rothwell
2010-02-28 7:51 ` Ingo Molnar
2010-02-28 8:19 ` Al Viro
2010-02-28 8:53 ` Ingo Molnar
2010-02-28 10:26 ` Stephen Rothwell
2010-02-28 7:23 ` Ingo Molnar
2010-03-01 15:13 ` Nick Bowler
2010-03-03 21:53 ` Pavel Machek
2010-03-04 0:35 ` Thomas Gleixner
2010-03-04 0:42 ` Andrew Morton
2010-03-04 1:17 ` Thomas Gleixner
2010-03-04 2:48 ` Ingo Molnar
2010-02-22 18:37 ` [tip:x86/ptrace] ptrace: Add support for generic PTRACE_GETREGSET/PTRACE_SETREGSET Roland McGrath
2010-02-23 18:36 ` [tip:x86/ptrace] parisc: Disable CONFIG_HAVE_ARCH_TRACEHOOK tip-bot for Roland McGrath
2010-02-12 3:56 ` [patch v3 2/2] ptrace: Add support for generic PTRACE_GETREGSET/PTRACE_SETREGSET Roland McGrath
2010-02-12 15:59 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100212155955.GA16870@redhat.com \
--to=oleg@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peter.lachner@intel.com \
--cc=roland@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.