All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Bart De Schuymer <bdschuym@pandora.be>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2 0/10] netfilter: ebtables: CONFIG_COMPAT support
Date: Sat, 13 Feb 2010 14:31:53 +0100	[thread overview]
Message-ID: <20100213133153.GE27427@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <4B76A730.4000203@pandora.be>

Bart De Schuymer <bdschuym@pandora.be> wrote:
> > First patches are minor bug fixes/preparation patches.  Patch 7 is the
> > main CONFIG_COMPAT hunk, 8 handles those ebtables binaries specifically
> > built for 64 bit kernel (i.e. pad in userspace).
> > 
> > Last two patches add CONFIG_COMPAT support to the targets/matches that
> > need special handling (maybe I missed some, though).
> > 
> > Tested on x86_64 with x86 userland by comparing output of 32 and 64 bit ebtables binaries.
> 
> One little cleanup that could be done is remove the last use of MEMPRINT
> and the corresponding macro in patch 5/10.

Okay, I'll do that then in the next iteration.

> For patch 8/10, I'd just remove the BUGPRINT line instead of adding the
> compat argument to copy_counters_to_user().

Perfect, I was a bit concerned if removing it would be acceptable; thats
the sole reason I added this ugly "bool compat" argument...

I'll just remove it, thanks Bart.

> But apart from that, the patches look ok to me (patch 10 was missing I
> think).

Whoops. Proabably because I ran send-email 000* .
It was unchanged from v1, though (except added const qualifiers).

Thanks a lot for taking the time to review this.

Regards, Florian

      reply	other threads:[~2010-02-13 13:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-11 14:12 [PATCH v2 0/10] netfilter: ebtables: CONFIG_COMPAT support Florian Westphal
2010-02-11 14:12 ` [PATCH 01/10] netfilter: ebtables: abort if next_offset is too small Florian Westphal
2010-02-15 17:40   ` Patrick McHardy
2010-02-11 14:12 ` [PATCH 02/10] netfilter: ebtables: avoid explicit XT_ALIGN() in match/targets Florian Westphal
2010-02-15 17:40   ` Patrick McHardy
2010-02-11 14:12 ` [PATCH 03/10] netfilter: CONFIG_COMPAT: allow delta to exceed 32767 Florian Westphal
2010-02-15 16:33   ` Patrick McHardy
2010-02-15 16:37     ` Florian Westphal
2010-02-15 17:08       ` Patrick McHardy
2010-02-15 17:40   ` Patrick McHardy
2010-02-11 14:12 ` [PATCH 04/10] netfilter: ebtables: split do_replace into two functions Florian Westphal
2010-02-11 14:12 ` [PATCH 05/10] netfilter: ebtables: split copy_everything_to_user " Florian Westphal
2010-02-11 14:12 ` [PATCH 06/10] netfilter: ebtables: split update_counters " Florian Westphal
2010-02-11 14:12 ` [PATCH 07/10] netfilter: ebtables: add CONFIG_COMPAT support Florian Westphal
2010-02-11 14:12 ` [PATCH 08/10] netfilter: ebtables: try native set/getsockopt handlers, too Florian Westphal
2010-02-11 17:40   ` Patrick McHardy
2010-02-11 21:50     ` Florian Westphal
2010-02-11 14:12 ` [PATCH 09/10] netfilter: ebt_limit: add CONFIG_COMPAT support Florian Westphal
2010-02-13 13:20 ` [PATCH v2 0/10] netfilter: ebtables: " Bart De Schuymer
2010-02-13 13:31   ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100213133153.GE27427@Chamillionaire.breakpoint.cc \
    --to=fw@strlen.de \
    --cc=bdschuym@pandora.be \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.