From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752980Ab0BNTt4 (ORCPT ); Sun, 14 Feb 2010 14:49:56 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:39398 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752358Ab0BNTty (ORCPT ); Sun, 14 Feb 2010 14:49:54 -0500 Date: Sun, 14 Feb 2010 11:50:07 -0800 (PST) Message-Id: <20100214.115007.94112348.davem@davemloft.net> To: grant.likely@secretlab.ca Cc: monstr@monstr.eu, sfr@canb.auug.org.au, benh@kernel.crashing.org, jeremy.kerr@canonical.com, microblaze-uclinux@itee.uq.edu.au, linuxppc-dev@ozlabs.org, sparclinux@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/9] of/sparc: Remove sparc-local declaration of allnodes and devtree_lock From: David Miller In-Reply-To: <20100213160309.4767.94443.stgit@angua> References: <20100213154838.4767.83881.stgit@angua> <20100213160309.4767.94443.stgit@angua> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Grant Likely Date: Sat, 13 Feb 2010 09:03:09 -0700 > Both allnodes and devtree_lock are defined in common code. The > extern declaration should be in the common header too so that the > compiler can type check. allnodes is already in of.h, but > devtree_lock should be declared there too. > > This patch removes the SPARC declarations and uses decls in of.h instead. > > Signed-off-by: Grant Likely Acked-by: David S. Miller From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Sun, 14 Feb 2010 19:50:07 +0000 Subject: Re: [PATCH 8/9] of/sparc: Remove sparc-local declaration of Message-Id: <20100214.115007.94112348.davem@davemloft.net> List-Id: References: <20100213154838.4767.83881.stgit@angua> <20100213160309.4767.94443.stgit@angua> In-Reply-To: <20100213160309.4767.94443.stgit@angua> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: grant.likely@secretlab.ca Cc: monstr@monstr.eu, sfr@canb.auug.org.au, benh@kernel.crashing.org, jeremy.kerr@canonical.com, microblaze-uclinux@itee.uq.edu.au, linuxppc-dev@ozlabs.org, sparclinux@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org From: Grant Likely Date: Sat, 13 Feb 2010 09:03:09 -0700 > Both allnodes and devtree_lock are defined in common code. The > extern declaration should be in the common header too so that the > compiler can type check. allnodes is already in of.h, but > devtree_lock should be declared there too. > > This patch removes the SPARC declarations and uses decls in of.h instead. > > Signed-off-by: Grant Likely Acked-by: David S. Miller From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sunset.davemloft.net (74-93-104-97-Washington.hfc.comcastbusiness.net [74.93.104.97]) by ozlabs.org (Postfix) with ESMTP id AB2C2B7C09 for ; Mon, 15 Feb 2010 06:49:54 +1100 (EST) Date: Sun, 14 Feb 2010 11:50:07 -0800 (PST) Message-Id: <20100214.115007.94112348.davem@davemloft.net> To: grant.likely@secretlab.ca Subject: Re: [PATCH 8/9] of/sparc: Remove sparc-local declaration of allnodes and devtree_lock From: David Miller In-Reply-To: <20100213160309.4767.94443.stgit@angua> References: <20100213154838.4767.83881.stgit@angua> <20100213160309.4767.94443.stgit@angua> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Cc: sfr@canb.auug.org.au, monstr@monstr.eu, microblaze-uclinux@itee.uq.edu.au, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, sparclinux@vger.kernel.org, jeremy.kerr@canonical.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Grant Likely Date: Sat, 13 Feb 2010 09:03:09 -0700 > Both allnodes and devtree_lock are defined in common code. The > extern declaration should be in the common header too so that the > compiler can type check. allnodes is already in of.h, but > devtree_lock should be declared there too. > > This patch removes the SPARC declarations and uses decls in of.h instead. > > Signed-off-by: Grant Likely Acked-by: David S. Miller