From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin O'Connor Subject: Re: [PATCH] Seabios - read e820 table from qemu_cfg Date: Sat, 13 Feb 2010 22:16:57 -0500 Message-ID: <20100214031657.GB4656@morn.localdomain> References: <4B5DCAF2.3010105@redhat.com> <20100126002447.GA8800@morn.localdomain> <4B5F640C.2030907@redhat.com> <20100128043917.GA3623@morn.localdomain> <4B6FE80C.2060408@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity , Anthony Liguori , seabios@seabios.org, Alexander Graf To: Jes Sorensen Return-path: Received: from mail-vw0-f46.google.com ([209.85.212.46]:44025 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758060Ab0BNDRF (ORCPT ); Sat, 13 Feb 2010 22:17:05 -0500 Received: by vws20 with SMTP id 20so1202685vws.19 for ; Sat, 13 Feb 2010 19:17:01 -0800 (PST) Content-Disposition: inline In-Reply-To: <4B6FE80C.2060408@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Feb 08, 2010 at 11:31:40AM +0100, Jes Sorensen wrote: > On 01/28/10 05:39, Kevin O'Connor wrote: > >As a side note, it should probably do the e820 map check even for qemu > >users (ie, not just kvm). > > Hi Kevin, > > Here is an updated version of the patch which does the e820 read > unconditionally of the return from kvm_para_available() so it should > work for coreboot too. > > I haven't touched the file descriptor issue as I find it's a different > discussion. I'd prefer to use the "file" method - but I wont hold up your patch for it. If the host part of your patch is committed to qemu, I'll commit the SeaBIOS part. [...] > +struct e820_entry { > + u64 address; > + u64 length; > + u32 type; > +}; I find this struct to be easily confused with 'struct e820entry' in memmap.h. Both code should use the same struct, or the new struct should clearly indicate it's for qemu (eg, "qemu_e820_entry"). Thanks, -Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NgUyn-0005u4-1u for qemu-devel@nongnu.org; Sat, 13 Feb 2010 22:17:05 -0500 Received: from [199.232.76.173] (port=52738 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NgUyl-0005tg-Ng for qemu-devel@nongnu.org; Sat, 13 Feb 2010 22:17:03 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NgUyk-0004MZ-DA for qemu-devel@nongnu.org; Sat, 13 Feb 2010 22:17:03 -0500 Received: from mail-vw0-f45.google.com ([209.85.212.45]:51739) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NgUyk-0004MT-5W for qemu-devel@nongnu.org; Sat, 13 Feb 2010 22:17:02 -0500 Received: by vws11 with SMTP id 11so979999vws.4 for ; Sat, 13 Feb 2010 19:17:01 -0800 (PST) Date: Sat, 13 Feb 2010 22:16:57 -0500 From: Kevin O'Connor Message-ID: <20100214031657.GB4656@morn.localdomain> References: <4B5DCAF2.3010105@redhat.com> <20100126002447.GA8800@morn.localdomain> <4B5F640C.2030907@redhat.com> <20100128043917.GA3623@morn.localdomain> <4B6FE80C.2060408@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B6FE80C.2060408@redhat.com> Subject: [Qemu-devel] Re: [PATCH] Seabios - read e820 table from qemu_cfg List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: Anthony Liguori , kvm@vger.kernel.org, seabios@seabios.org, Alexander Graf , qemu-devel@nongnu.org, Avi Kivity On Mon, Feb 08, 2010 at 11:31:40AM +0100, Jes Sorensen wrote: > On 01/28/10 05:39, Kevin O'Connor wrote: > >As a side note, it should probably do the e820 map check even for qemu > >users (ie, not just kvm). > > Hi Kevin, > > Here is an updated version of the patch which does the e820 read > unconditionally of the return from kvm_para_available() so it should > work for coreboot too. > > I haven't touched the file descriptor issue as I find it's a different > discussion. I'd prefer to use the "file" method - but I wont hold up your patch for it. If the host part of your patch is committed to qemu, I'll commit the SeaBIOS part. [...] > +struct e820_entry { > + u64 address; > + u64 length; > + u32 type; > +}; I find this struct to be easily confused with 'struct e820entry' in memmap.h. Both code should use the same struct, or the new struct should clearly indicate it's for qemu (eg, "qemu_e820_entry"). Thanks, -Kevin