All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: "Varadarajan, Charulatha" <charu@ti.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH 0/4 RFC]OMAP:GPIO: Make GPIO an early init device
Date: Mon, 15 Feb 2010 09:49:28 -0800	[thread overview]
Message-ID: <20100215174928.GC21755@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1002141837240.28188@utopia.booyaka.com>

* Paul Walmsley <paul@pwsan.com> [100214 17:38]:
> On Fri, 12 Feb 2010, Paul Walmsley wrote:
> 
> > On Fri, 12 Feb 2010, Varadarajan, Charulatha wrote:
> > 
> > >   OMAP: Convert GPIO into a early driver
> > 
> > The above patch appears to be missing.  Could you please re-send?
> 
> This patch was too big for the mailing list, so it's been posted here:
> 
> http://www.pwsan.com/omap/patches/gpio/0002-OMAP-GPIO-split-omap1-and-omap2.patch

What, make two almost identical copies of the shared code? No way!
Instead, please keep the common code under plat-omap:

arch/arm/plat-omap/gpio.c

Then implement the processor specific functions:

arch/arm/mach-omap1/gpio.c
arch/arm/mach-omap2/gpio.c
arch/arm/mach-omap2/gpio24xx.c
arch/arm/mach-omap2/gpio44xx.c

Then have a subsys_initcall in processor specific implementation
that sets the function pointers in the common code.

Regards,

Tony

  reply	other threads:[~2010-02-15 17:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-12 13:37 [PATCH 0/4 RFC]OMAP:GPIO: Make GPIO an early init device Varadarajan, Charulatha
2010-02-12 13:37 ` [PATCH 1/4 RFC]OMAP2: Fix compile errors Varadarajan, Charulatha
     [not found]   ` <1265981851-11970-3-git-send-email-charu@ti.com>
2010-02-12 13:37     ` [PATCH 3/4 RFC]OMAP:Convert GPIO into a early driver Varadarajan, Charulatha
2010-02-12 13:37       ` [PATCH 4/4 RFC]OMAP:GPIO: Convert all printk's to pr_* in gpio Varadarajan, Charulatha
2010-02-16 23:15   ` [PATCH 1/4 RFC]OMAP2: Fix compile errors Kevin Hilman
2010-03-17 15:12     ` compilation error on hwmods branch Varadarajan, Charulatha
2010-03-17 17:03       ` Tony Lindgren
2010-03-17 17:45         ` Kevin Hilman
2010-02-12 22:31 ` [PATCH 0/4 RFC]OMAP:GPIO: Make GPIO an early init device Paul Walmsley
2010-02-15  1:38   ` Paul Walmsley
2010-02-15 17:49     ` Tony Lindgren [this message]
2010-02-16 15:06       ` Varadarajan, Charulatha
2010-02-16 19:46         ` Tony Lindgren
2010-03-17 14:10           ` Varadarajan, Charulatha
2010-03-17 23:19             ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100215174928.GC21755@atomide.com \
    --to=tony@atomide.com \
    --cc=charu@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.