From: David Miller <davem@davemloft.net>
To: ajitk@serverengines.com, ajitkhaparde@gmail.com
Cc: herbert@gondor.apana.org.au, kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6] net: bug fix for vlan + gro issue
Date: Wed, 17 Feb 2010 16:02:51 -0800 (PST) [thread overview]
Message-ID: <20100217.160251.170027820.davem@davemloft.net> (raw)
In-Reply-To: <20100217062541.GA10350@serverengines.com>
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Wed, 17 Feb 2010 11:55:43 +0530
> Thanks Herbert. I think you meant something like this:
> + skb->protocol = eth_type_trans(skb, skb->dev);
>
> Here is the patch:-
>
> Traffic (tcp) doesnot start on a vlan interface when gro is enabled.
> Even the tcp handshake was not taking place.
> This is because, the eth_type_trans call before the netif_receive_skb
> in napi_gro_finish() resets the skb->dev to napi->dev from the previously
> set vlan netdev interface. This causes the ip_route_input to drop the
> incoming packet considering it as a packet coming from a martian source.
>
> I could repro this on 2.6.32.7 (stable) and 2.6.33-rc7.
> With this fix, the traffic starts and the test runs fine on both vlan
> and non-vlan interfaces.
>
> CC: Herbert Xu <herbert@gondor.apana.org.au>
> CC: Patrick McHardy <kaber@trash.net>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied, thanks.
prev parent reply other threads:[~2010-02-18 0:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 5:34 [PATCH net-2.6] net: bug fix for vlan + gro issue Ajit Khaparde
2010-02-16 11:40 ` Herbert Xu
2010-02-17 6:25 ` Ajit Khaparde
2010-02-17 6:40 ` Herbert Xu
2010-02-18 0:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217.160251.170027820.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajitk@serverengines.com \
--cc=ajitkhaparde@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.