From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o1HMqVUJ005652 for ; Wed, 17 Feb 2010 16:52:31 -0600 Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 519E51CDB5EE for ; Wed, 17 Feb 2010 14:53:48 -0800 (PST) Received: from mail.internode.on.net (bld-mail13.adl6.internode.on.net [150.101.137.98]) by cuda.sgi.com with ESMTP id tr5oXY2Fj8XjCIRw for ; Wed, 17 Feb 2010 14:53:48 -0800 (PST) Date: Thu, 18 Feb 2010 09:53:45 +1100 From: Dave Chinner Subject: Re: [PATCH] xfs: fix inode pincount check in fsync Message-ID: <20100217225345.GT28392@discord.disaster> References: <20100217193457.GA21840@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100217193457.GA21840@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig , Christoph Hellwig Cc: xfs@oss.sgi.com On Wed, Feb 17, 2010 at 02:34:57PM -0500, Christoph Hellwig wrote: > We need to hold the ilock to check the inode pincount safely. While > we're at it also remove the check for ip->i_itemp->ili_last_lsn, a > pinned inode always has it set. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs