All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfs: cleanup xfs_iunpin_wait/xfs_iunpin_nowait
Date: Thu, 18 Feb 2010 09:57:16 +1100	[thread overview]
Message-ID: <20100217225716.GV28392@discord.disaster> (raw)
In-Reply-To: <20100217194356.GA28758@infradead.org>

On Wed, Feb 17, 2010 at 02:43:56PM -0500, Christoph Hellwig wrote:
> Remove the inode item pointer and ili_last_lsn checks in __xfs_iunpin_wait
> as any pinned inode is guaranteed to have them valid.  After this the
> xfs_iunpin_nowait case is nothing more than a xfs_log_force_lsn, as we
> know that the caller has already checked the pincount.
> 
> Make xfs_iunpin_nowait the new low-level routine just doing the log force
> and rewrite xfs_iunpin_wait around it.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Nice cleanup.

Reviewed-by: Dave Chinner <david@fromorbit.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2010-02-17 22:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-17 19:43 [PATCH 1/2] xfs: cleanup xfs_iunpin_wait/xfs_iunpin_nowait Christoph Hellwig
2010-02-17 22:57 ` Dave Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100217225716.GV28392@discord.disaster \
    --to=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.