All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Alan Cox <alan@linux.intel.com>,
	linux-kernel@vger.kernel.org, p.hardwick@option.com
Subject: Re: [PATCH 3/3] nozomi: Tidy up the PCI table
Date: Wed, 17 Feb 2010 14:59:35 -0800	[thread overview]
Message-ID: <20100217225935.GE31557@kroah.com> (raw)
In-Reply-To: <1265626189.31341.260.camel@localhost.localdomain>

On Mon, Feb 08, 2010 at 11:49:49AM +0100, Marcel Holtmann wrote:
> Hi Alan,
> 
> > Signed-off-by: Alan Cox <alan@linux.intel.com>
> > ---
> > 
> >  drivers/char/nozomi.c |    6 +-----
> >  1 files changed, 1 insertions(+), 5 deletions(-)
> > 
> > 
> > diff --git a/drivers/char/nozomi.c b/drivers/char/nozomi.c
> > index fac9157..86c9e64 100644
> > --- a/drivers/char/nozomi.c
> > +++ b/drivers/char/nozomi.c
> > @@ -136,10 +136,6 @@ static int debug;
> >  #define RECEIVE_BUF_MAX		4
> >  
> > 
> > -/* Define all types of vendors and devices to support */
> > -#define VENDOR1		0x1931	/* Vendor Option */
> > -#define DEVICE1		0x000c	/* HSDPA card */
> > -
> >  #define R_IIR		0x0000	/* Interrupt Identity Register */
> >  #define R_FCR		0x0000	/* Flow Control Register */
> >  #define R_IER		0x0004	/* Interrupt Enable Register */
> > @@ -407,7 +403,7 @@ struct buffer {
> >  
> >  /*    Global variables */
> >  static const struct pci_device_id nozomi_pci_tbl[] __devinitconst = {
> > -	{PCI_DEVICE(VENDOR1, DEVICE1)},
> > +	{PCI_DEVICE(0x1931, 0x000c)},	/* Nozomi HSPDA */
> >  	{},
> 
> that would be HSDPA actually.

I edited the patch, thanks.

greg k-h

  reply	other threads:[~2010-02-17 23:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-08 10:06 [PATCH 1/3] nozomi: Add tty_port usage Alan Cox
2010-02-08 10:07 ` [PATCH 2/3] nozomi: Fix mutex handling Alan Cox
2010-02-08 10:07 ` [PATCH 3/3] nozomi: Tidy up the PCI table Alan Cox
2010-02-08 10:49   ` Marcel Holtmann
2010-02-17 22:59     ` Greg KH [this message]
2010-02-17 12:59 [PATCH 1/3] nozomi: Add tty_port usage Alan Cox
2010-02-17 13:00 ` [PATCH 3/3] nozomi: Tidy up the PCI table Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100217225935.GE31557@kroah.com \
    --to=greg@kroah.com \
    --cc=alan@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=p.hardwick@option.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.