Re: [PATCH 5/6] Mailbox: sleeping function called from invalid context fix

[Hiroshi DOYU <Hiroshi.DOYU@nokia.com>]

From: ext Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 5/6] Mailbox: sleeping function called from invalid context fix
Date: Thu, 18 Feb 2010 02:05:10 +0100

> * Guzman Lugo, Fernando <x0095840@ti.com> [100215 23:22]:
>> 
>> Hi,
>> 
>> >-----Original Message-----
>> >From: Hiroshi DOYU [mailto:Hiroshi.DOYU@nokia.com]
>> >Sent: Monday, February 15, 2010 7:49 AM
>> >To: Guzman Lugo, Fernando
>> >Cc: linux-omap@vger.kernel.org
>> >Subject: Re: [PATCH 5/6] Mailbox: sleeping function called from invalid
>> >context fix
>> >
>> >Hi Fernando,
>> >
>> >From: "ext Guzman Lugo, Fernando" <x0095840@ti.com>
>> >Subject: [PATCH 5/6] Mailbox: sleeping function called from invalid context
>> >fix
>> >Date: Sat, 13 Feb 2010 02:42:16 +0100
>> >
>> >> From e06b2716824f225747c4dc83ed2623d0160ae132 Mon Sep 17 00:00:00 2001
>> >> From: Fernando Guzman Lugo <x0095840@ti.com>
>> >> Date: Fri, 29 Jan 2010 17:12:24 -0600
>> >> Subject: [PATCH] Mailbox: sleeping function called from invalid context
>> >fix
>> >>
>> >> This patch fixes this bug:
>> >> BUG: sleeping function called from invalid context
>> >> Inside omap2_mbox_startup is called clk_get_sys that can sleep,
>> >> therefore omap2_mbox_startup can sleep but it is call in an atomic
>> >> context . So the spinlock is change for a semaphore.
>> >
>> >"mboxes_lock" is used to maintain the global list of mailbox
>> >instances, which belong to a single mailbox H/W module, but they are
>> >logical channels from S/W perspective. Both "->ops->startup()" and
>> >"->ops->shutdown()" are being executed against the above single H/W
>> >module, and a mailbox H/W module is totally __independent__ of the
>> >registration of logical mailboxes, which are (un)registered with
>> 
>> Yes, they are independent of each other, and can be executed at the same time. I am agreed with your patch; that should be the right solution, so you can drop my patch.
> 
> Hiroshi & Fernando, if you want me to merge this series, please post
> it one more time with right patches and ack's from Hiroshi. Please
> Cc also linux-arm-kernel so it gets reviewed there. The merge window
> is about to open, so we're running out of time..

Ok, I'll take care of them.