From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 06/19] ext2: replace inode uid,gid,mode initialization with helper function Date: Thu, 18 Feb 2010 02:21:28 +0100 Message-ID: <20100218012128.GA8897@atrey.karlin.mff.cuni.cz> References: <1266431353-8549-1-git-send-email-dmonakhov@openvz.org> <1266432013-9241-1-git-send-email-dmonakhov@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org To: Dmitry Monakhov Return-path: Received: from ksp.mff.cuni.cz ([195.113.26.206]:34487 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753797Ab0BRByV (ORCPT ); Wed, 17 Feb 2010 20:54:21 -0500 Content-Disposition: inline In-Reply-To: <1266432013-9241-1-git-send-email-dmonakhov@openvz.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > > Signed-off-by: Dmitry Monakhov > --- > fs/ext2/ialloc.c | 12 ++++-------- > 1 files changed, 4 insertions(+), 8 deletions(-) > > diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c > index 15387c9..4a4b132 100644 > --- a/fs/ext2/ialloc.c > +++ b/fs/ext2/ialloc.c > @@ -550,16 +550,12 @@ got: > > sb->s_dirt = 1; > mark_buffer_dirty(bh2); > - inode->i_uid = current_fsuid(); > - if (test_opt (sb, GRPID)) > + if (test_opt (sb, GRPID)) { As Andreas wrote, please don't use space after a function name. Otherwise the patch looks fine. Honza > + inode->i_mode = mode; > + inode->i_uid = current_fsuid(); > inode->i_gid = dir->i_gid; > - else if (dir->i_mode & S_ISGID) { > - inode->i_gid = dir->i_gid; > - if (S_ISDIR(mode)) > - mode |= S_ISGID; > } else > - inode->i_gid = current_fsgid(); > - inode->i_mode = mode; > + inode_init_owner(inode, dir, mode); > > inode->i_ino = ino; > inode->i_blocks = 0; > -- > 1.6.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jan Kara SuSE CR Labs