All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.sourceforge.net
Subject: [Bug 26641] RV730 agp xf86-video-ati with kms poor performance
Date: Thu, 18 Feb 2010 17:25:32 -0800 (PST)	[thread overview]
Message-ID: <20100219012532.D6CDE1300D9@annarchy.freedesktop.org> (raw)
In-Reply-To: <bug-26641-502@http.bugs.freedesktop.org/>

http://bugs.freedesktop.org/show_bug.cgi?id=26641





--- Comment #3 from Andy Furniss <lists@andyfurniss.entadsl.com>  2010-02-18 17:25:32 PST ---
(In reply to comment #0)

> I use kernel 2.6.33 rc8 with ati kms support.

I have a similar sounding problem on an AGP card since early Feb.

http://article.gmane.org/gmane.comp.video.dri.devel/42770

As I am running git drm-radeon-testing, to fix all I need to do is -

git revert db78e27de7e29a6db6be7caf607cf803d84094aa

I suppose you could try making a normal diff out of the revert below.

    Revert "drm/ttm: Avoid conflicting reserve_memtype during
ttm_tt_set_page_caching."

    This reverts commit db78e27de7e29a6db6be7caf607cf803d84094aa.

diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
index e2123af..9c2b1cc 100644
--- a/drivers/gpu/drm/ttm/ttm_tt.c
+++ b/drivers/gpu/drm/ttm/ttm_tt.c
@@ -198,26 +198,17 @@ EXPORT_SYMBOL(ttm_tt_populate);
 static inline int ttm_tt_set_page_caching(struct page *p,
                                          enum ttm_caching_state c_state)
 {
-       int ret = 0;
-
        if (PageHighMem(p))
                return 0;

-       if (get_page_memtype(p) != -1) {
-               /* p isn't in the default caching state, set it to
-                * writeback first to free its current memtype. */
-
-               ret = set_pages_wb(p, 1);
-               if (ret)
-                       return ret;
+       switch (c_state) {
+       case tt_cached:
+               return set_pages_wb(p, 1);
+       case tt_wc:
+           return set_memory_wc((unsigned long) page_address(p), 1);
+       default:
+               return set_pages_uc(p, 1);
        }
-
-       if (c_state == tt_wc)
-               ret = set_memory_wc((unsigned long) page_address(p), 1);
-       else if (c_state == tt_uncached)
-               ret = set_pages_uc(p, 1);
-
-       return ret;
 }
 #else /* CONFIG_X86 */
 static inline int ttm_tt_set_page_caching(struct page *p,


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

  parent reply	other threads:[~2010-02-19  1:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-18 23:46 [Bug 26641] New: " bugzilla-daemon
2010-02-18 23:50 ` [Bug 26641] " bugzilla-daemon
2010-02-19  0:44 ` bugzilla-daemon
2010-02-19  1:25 ` bugzilla-daemon [this message]
2010-02-19  1:30 ` bugzilla-daemon
2010-02-19 19:43 ` bugzilla-daemon
2010-02-19 22:40 ` bugzilla-daemon
2010-02-19 22:52 ` bugzilla-daemon
2010-02-20  0:13 ` bugzilla-daemon
2010-03-09 19:38 ` bugzilla-daemon
2010-03-15 12:23 ` bugzilla-daemon
2010-03-15 16:58 ` bugzilla-daemon
2010-03-15 18:15 ` bugzilla-daemon
2010-04-08  0:06 ` bugzilla-daemon
2010-04-08 13:45 ` bugzilla-daemon
2010-04-20 11:32 ` bugzilla-daemon
2012-09-11 17:32 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100219012532.D6CDE1300D9@annarchy.freedesktop.org \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.sourceforge.net \
    --subject='Re: [Bug 26641] RV730 agp xf86-video-ati with kms poor performance' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.