All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bruno Prémont" <bonbons@linux-vserver.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Rick L. Vinyard Jr." <rvinyard@cs.nmsu.edu>,
	Nicu Pavel <npavel@ituner.com>
Subject: [PATCH 2/3] hid: add suspend/resume hooks for hid drivers
Date: Wed, 24 Feb 2010 17:01:12 +0100	[thread overview]
Message-ID: <20100224170112.576403ee@neptune.home> (raw)
In-Reply-To: <20100224163101.3622d69f@neptune.home>

Add suspend/resume hooks for HID drivers so these can do some
additional state adjustment when device gets suspended/resumed.

This patch calls these hooks from usbhid suspend/resume functions,
only calling suspend on plain suspend, not autosuspend.
(it might be worth adding an autosuspend parameter to suspend
hook and calling suspend in both cases)

Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
---
 drivers/hid/hid-core.c              |   19 ++-
 include/linux/hid.h                 |    8 +
 2 files changed, 36 insertions(+), 1 deletions(-)

diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
index e2997a8..8ad1a98 100644
--- a/drivers/hid/usbhid/hid-core.c
+++ b/drivers/hid/usbhid/hid-core.c
@@ -1272,6 +1272,11 @@ static int hid_suspend(struct usb_interface *intf, pm_message_t message)
 		}
 
 	} else {
+		if (hid->driver && hid->driver->suspend) {
+			status = hid->driver->suspend(hid);
+			if (status < 0)
+				return status;
+		}
 		spin_lock_irq(&usbhid->lock);
 		set_bit(HID_REPORTED_IDLE, &usbhid->iofl);
 		spin_unlock_irq(&usbhid->lock);
@@ -1326,6 +1331,11 @@ static int hid_resume(struct usb_interface *intf)
 		hid_io_error(hid);
 	usbhid_restart_queues(usbhid);
 
+	if (hid->driver && hid->driver->resume) {
+		int ret = hid->driver->resume(hid);
+		if (ret < 0 && status == 0)
+			status = ret;
+	}
 	dev_dbg(&intf->dev, "resume status %d\n", status);
 	return 0;
 }
@@ -1334,9 +1344,16 @@ static int hid_reset_resume(struct usb_interface *intf)
 {
 	struct hid_device *hid = usb_get_intfdata(intf);
 	struct usbhid_device *usbhid = hid->driver_data;
+	int status;
 
 	clear_bit(HID_REPORTED_IDLE, &usbhid->iofl);
-	return hid_post_reset(intf);
+	status = hid_post_reset(intf);
+	if (hid->driver && hid->driver->reset_resume) {
+		int ret = hid->driver->reset_resume(hid);
+		if (ret < 0 && status == 0)
+			status = ret;
+	}
+	return status;
 }
 
 #endif /* CONFIG_PM */
diff --git a/include/linux/hid.h b/include/linux/hid.h
index 8709365..b4409f1 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -589,6 +589,9 @@ struct hid_usage_id {
  * @report_fixup: called before report descriptor parsing (NULL means nop)
  * @input_mapping: invoked on input registering before mapping an usage
  * @input_mapped: invoked on input registering after mapping an usage
+ * @suspend: invoked on suspend (NULL means nop)
+ * @resume: invoked on resume if device was not reset (NULL means nop)
+ * @reset_resume: invoked on resume if device was reset (NULL means nop)
  *
  * raw_event and event should return 0 on no action performed, 1 when no
  * further processing should be done and negative on error
@@ -629,6 +632,11 @@ struct hid_driver {
 	int (*input_mapped)(struct hid_device *hdev,
 			struct hid_input *hidinput, struct hid_field *field,
 			struct hid_usage *usage, unsigned long **bit, int *max);
+#ifdef CONFIG_PM
+	int (*suspend)(struct hid_device *hdev);
+	int (*resume)(struct hid_device *hdev);
+	int (*reset_resume)(struct hid_device *hdev);
+#endif
 /* private: */
 	struct device_driver driver;
 };

  reply	other threads:[~2010-02-24 16:02 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-20 23:10 [Patch 0/3] backlight Bruno Prémont
2010-02-20 23:10 ` Bruno Prémont
2010-02-20 23:18 ` [PATCH 2/3] backlight: mark struct backlight_ops const Bruno Prémont
2010-02-20 23:18   ` Bruno Prémont
2010-02-20 23:18   ` Bruno Prémont
2010-02-20 23:18   ` Bruno Prémont
     [not found]   ` <20100221001851.673db863-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2010-02-22 19:35     ` Mike Frysinger
2010-02-22 19:35       ` Mike Frysinger
2010-02-22 19:35       ` Mike Frysinger
2010-02-22 19:35       ` Mike Frysinger
2010-02-26 11:56   ` [PATCH] " Bruno Prémont
2010-02-26 11:56     ` Bruno Prémont
2010-02-20 23:20 ` [PATCH 1/3] backlight: Add backlight_device parameter to check_fb Bruno Prémont
2010-02-20 23:20   ` Bruno Prémont
2010-02-24 16:00   ` [PATCH 1/3] picolcd: driver for PicoLCD HID device Bruno Prémont
2010-02-24 16:00     ` Bruno Prémont
2010-02-24 16:00     ` Bruno Prémont
2010-02-24 16:01     ` Bruno Prémont [this message]
2010-02-25  4:19       ` [PATCH 2/3] hid: add suspend/resume hooks for hid drivers Oliver Neukum
2010-02-25 10:12         ` Bruno Prémont
2010-02-24 16:01     ` [PATCH 3/3] hid-picolcd: make use of new suspend/resume hooks Bruno Prémont
2010-02-24 16:01       ` Bruno Prémont
2010-02-24 18:27     ` [PATCH 1/3] picolcd: driver for PicoLCD HID device Oliver Neukum
2010-02-24 18:27       ` Oliver Neukum
2010-02-24 18:27       ` Oliver Neukum
2010-02-24 21:44       ` Rick L. Vinyard, Jr.
2010-02-24 21:44         ` Rick L. Vinyard, Jr.
2010-02-24 21:44         ` Rick L. Vinyard, Jr.
2010-02-25  4:11         ` Oliver Neukum
2010-02-25  4:11           ` Oliver Neukum
2010-02-25 11:00         ` Jiri Kosina
2010-02-25 11:00           ` Jiri Kosina
2010-02-25 15:34           ` Rick L. Vinyard, Jr.
2010-02-25 15:34             ` Rick L. Vinyard, Jr.
2010-02-26  8:12             ` Dmitry Torokhov
2010-02-26  8:12               ` Dmitry Torokhov
2010-02-25 11:07     ` Jiri Kosina
2010-02-25 11:07       ` Jiri Kosina
2010-02-25 11:07       ` Jiri Kosina
2010-02-25 11:32       ` Bruno Prémont
2010-02-25 11:32         ` Bruno Prémont
2010-02-25 11:32         ` Bruno Prémont
2010-02-25 15:18         ` Jiri Kosina
2010-02-25 15:18           ` Jiri Kosina
2010-02-25 15:18           ` Jiri Kosina
2010-02-25 15:29           ` Bruno Prémont
2010-02-25 15:29             ` Bruno Prémont
2010-03-13 19:39           ` Bruno Prémont
2010-03-13 19:39             ` Bruno Prémont
2010-03-13 21:35             ` Alan Stern
2010-03-13 21:35               ` Alan Stern
2010-03-13 22:13               ` [PATCH] hid: Register debugfs entries before adding device Bruno Prémont
2010-03-13 22:13                 ` Bruno Prémont
2010-03-15 13:48                 ` Jiri Kosina
2010-02-25 17:52         ` [PATCH 1/3] picolcd: driver for PicoLCD HID device Rick L. Vinyard, Jr.
2010-02-25 17:52           ` Rick L. Vinyard, Jr.
2010-02-25 17:52           ` Rick L. Vinyard, Jr.
2010-02-26  8:15       ` Dmitry Torokhov
2010-02-26  8:15         ` Dmitry Torokhov
2010-02-26  8:15         ` Dmitry Torokhov
2010-03-03  6:04     ` Pavel Machek
2010-03-03  6:04       ` Pavel Machek
2010-02-26 11:53   ` [PATCH] backlight: Add backlight_device parameter to check_fb Bruno Prémont
2010-02-26 11:53     ` Bruno Prémont
2010-02-20 23:28 ` [PATCH 3/3] backlight: fix missing/incomplete registration failure handling Bruno Prémont
2010-02-20 23:28   ` [PATCH 3/3] backlight: fix missing/incomplete registration failure Bruno Prémont
2010-02-21  8:04   ` [PATCH 3/3] backlight: fix missing/incomplete registration failure handling Harald Welte
2010-02-21 13:35   ` Thadeu Lima de Souza Cascardo
2010-02-21 13:35     ` [PATCH 3/3] backlight: fix missing/incomplete registration Thadeu Lima de Souza Cascardo
2010-02-24 15:33     ` [PATCH 3/3] backlight: fix missing/incomplete registration failure handling Anisse Astier
2010-02-24 15:33       ` [PATCH 3/3] backlight: fix missing/incomplete registration Anisse Astier
2010-02-26 11:59   ` [PATCH] backlight, classmate-laptop: fix missing registration failure handling Bruno Prémont
2010-02-26 16:20     ` Thadeu Lima de Souza Cascardo
2010-02-26 16:32       ` Matthew Garrett
2010-02-26 16:45         ` Richard Purdie
2010-02-26 22:25           ` Bruno Prémont
2010-02-26 12:02   ` [PATCH] backlight, appledisplay: fix incomplete " Bruno Prémont
2010-02-26 12:04   ` [PATCH] backlight, blackfin: fix missing " Bruno Prémont
2010-02-26 12:04     ` [PATCH] backlight, blackfin: fix missing registration failure Bruno Prémont
2010-02-26 12:17   ` [PATCH] backlight, msi-laptop, msi-wmi: fix incomplete registration failure handling Bruno Prémont
2010-02-26 12:20   ` [PATCH] backlight, panasonic-laptop: " Bruno Prémont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100224170112.576403ee@neptune.home \
    --to=bonbons@linux-vserver.org \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=npavel@ituner.com \
    --cc=rvinyard@cs.nmsu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.