From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Alan Jenkins <sourcejedi.lkml@googlemail.com>
Cc: Mel Gorman <mel@csn.ul.ie>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
hugh.dickins@tiscali.co.uk,
pm list <linux-pm@lists.linux-foundation.org>,
Kernel Testers List <kernel-testers@vger.kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: s2disk hang update
Date: Thu, 25 Feb 2010 21:04:51 +0100 [thread overview]
Message-ID: <201002252104.51187.rjw__8615.34290384061$1267128318$gmane$org@sisk.pl> (raw)
In-Reply-To: <9b2b86521002250510m75c8b314o37388a04b53a2b67@mail.gmail.com>
On Thursday 25 February 2010, Alan Jenkins wrote:
> On 2/24/10, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > On Wednesday 24 February 2010, Alan Jenkins wrote:
...
>
> > - while (to_free_normal > 0 && to_free_highmem > 0) {
> > + while (to_free_normal > 0 || to_free_highmem > 0) {
>
> Yes, that seems to do it. No more hangs so far (and I can still
> reproduce the hang with too many applications if I un-apply the
> patch).
OK, great. Is this with or without the NOIO-enforcing patch?
> I did see a non-fatal allocation failure though, so I'm still not sure
> that the current implementation is strictly correct.
>
> This is without the patch to increase "to_free_normal". If I get the
> allocation failure again, should I try testing the "free 20% extra"
> patch?
Either that or try to increase SPARE_PAGES. That should actually work with
the last patch applied. :-)
Rafael
next prev parent reply other threads:[~2010-02-25 20:04 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-02 15:03 s2disk hang update Alan Jenkins
2010-01-02 15:03 ` Alan Jenkins
2010-01-02 20:38 ` Rafael J. Wysocki
2010-01-02 20:38 ` Rafael J. Wysocki
2010-01-02 20:38 ` Rafael J. Wysocki
2010-02-02 14:21 ` Alan Jenkins
2010-02-02 14:21 ` Alan Jenkins
2010-02-02 20:34 ` Rafael J. Wysocki
2010-02-02 20:34 ` Rafael J. Wysocki
2010-02-03 11:14 ` Alan Jenkins
2010-02-09 16:36 ` Alan Jenkins
2010-02-09 16:36 ` Alan Jenkins
2010-02-15 23:08 ` Rafael J. Wysocki
2010-02-15 23:08 ` Rafael J. Wysocki
2010-02-16 11:09 ` Alan Jenkins
2010-02-16 11:09 ` Alan Jenkins
2010-02-16 15:12 ` Alan Jenkins
2010-02-16 15:12 ` Alan Jenkins
2010-02-16 15:12 ` Alan Jenkins
2010-02-16 21:16 ` Rafael J. Wysocki
2010-02-16 21:16 ` Rafael J. Wysocki
2010-02-16 21:16 ` Rafael J. Wysocki
2010-02-17 11:27 ` Alan Jenkins
2010-02-17 11:27 ` Alan Jenkins
2010-02-17 11:27 ` Alan Jenkins
2010-02-17 19:58 ` Rafael J. Wysocki
2010-02-17 19:58 ` Rafael J. Wysocki
2010-02-18 12:53 ` Alan Jenkins
2010-02-18 12:53 ` Alan Jenkins
2010-02-18 12:53 ` Alan Jenkins
2010-02-18 20:04 ` Rafael J. Wysocki
2010-02-18 20:04 ` Rafael J. Wysocki
2010-02-19 11:48 ` Alan Jenkins
2010-02-19 11:48 ` Alan Jenkins
2010-02-19 11:48 ` Alan Jenkins
2010-02-21 20:47 ` Rafael J. Wysocki
2010-02-22 15:35 ` Alan Jenkins
2010-02-22 15:35 ` Alan Jenkins
2010-02-22 19:17 ` Rafael J. Wysocki
2010-02-22 19:17 ` Rafael J. Wysocki
2010-02-23 14:24 ` Alan Jenkins
2010-02-23 14:24 ` Alan Jenkins
2010-02-23 21:13 ` Rafael J. Wysocki
2010-02-23 21:13 ` Rafael J. Wysocki
2010-02-23 21:13 ` Rafael J. Wysocki
2010-02-23 21:13 ` Rafael J. Wysocki
2010-02-24 1:20 ` KAMEZAWA Hiroyuki
2010-02-24 1:20 ` KAMEZAWA Hiroyuki
2010-02-24 1:20 ` KAMEZAWA Hiroyuki
2010-02-24 1:20 ` KAMEZAWA Hiroyuki
2010-02-24 20:19 ` Alan Jenkins
2010-02-24 20:19 ` Alan Jenkins
2010-02-24 20:19 ` Alan Jenkins
2010-02-24 20:19 ` Alan Jenkins
2010-02-24 20:36 ` Rafael J. Wysocki
2010-02-24 20:36 ` Rafael J. Wysocki
2010-02-24 20:36 ` Rafael J. Wysocki
2010-02-24 20:36 ` Rafael J. Wysocki
2010-02-24 16:23 ` Alan Jenkins
2010-02-24 16:23 ` Alan Jenkins
2010-02-24 20:52 ` Rafael J. Wysocki
2010-02-24 20:52 ` Rafael J. Wysocki
2010-02-24 20:52 ` Rafael J. Wysocki
2010-02-25 13:10 ` Alan Jenkins
2010-02-25 13:10 ` Alan Jenkins
2010-02-25 13:10 ` Alan Jenkins
2010-02-25 20:04 ` Rafael J. Wysocki [this message]
2010-02-25 20:04 ` Rafael J. Wysocki
2010-02-25 20:04 ` Rafael J. Wysocki
2010-02-25 20:04 ` Rafael J. Wysocki
2010-02-26 9:26 ` Alan Jenkins
2010-02-26 9:26 ` Alan Jenkins
2010-02-26 9:26 ` Alan Jenkins
2010-02-26 9:26 ` Alan Jenkins
2010-02-25 13:10 ` Alan Jenkins
2010-02-24 20:52 ` Rafael J. Wysocki
2010-02-23 14:24 ` Alan Jenkins
2010-02-22 19:17 ` Rafael J. Wysocki
2010-02-22 15:35 ` Alan Jenkins
2010-02-18 20:04 ` Rafael J. Wysocki
2010-02-17 19:58 ` Rafael J. Wysocki
2010-02-16 11:09 ` Alan Jenkins
2010-02-15 23:08 ` Rafael J. Wysocki
2010-02-09 16:36 ` Alan Jenkins
2010-02-03 11:14 ` Alan Jenkins
2010-01-02 15:03 Alan Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='201002252104.51187.rjw__8615.34290384061$1267128318$gmane$org@sisk.pl' \
--to=rjw@sisk.pl \
--cc=hugh.dickins@tiscali.co.uk \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mel@csn.ul.ie \
--cc=sourcejedi.lkml@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.