From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965228Ab0BZP56 (ORCPT ); Fri, 26 Feb 2010 10:57:58 -0500 Received: from one.firstfloor.org ([213.235.205.2]:51439 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965189Ab0BZP55 (ORCPT ); Fri, 26 Feb 2010 10:57:57 -0500 Date: Fri, 26 Feb 2010 16:57:55 +0100 From: Andi Kleen To: Christoph Lameter Cc: Andi Kleen , David Rientjes , Pekka Enberg , Nick Piggin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, haicheng.li@intel.com, KAMEZAWA Hiroyuki Subject: Re: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap Message-ID: <20100226155755.GE16335@basil.fritz.box> References: <20100215105253.GE21783@one.firstfloor.org> <20100215110135.GN5723@laptop> <20100220090154.GB11287@basil.fritz.box> <4B862623.5090608@cs.helsinki.fi> <20100226114136.GA16335@basil.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2010 at 09:04:56AM -0600, Christoph Lameter wrote: > On Fri, 26 Feb 2010, Andi Kleen wrote: > > > Memory hotplug with node add never quite worked on x86 before, > > for various reasons not related to slab. > > Ok but why did things break in such a big way? 1) numa memory hotadd never worked 2) the rest just bitrotted because nobody tested it. -Andi -- ak@linux.intel.com -- Speaking for myself only. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id 2ACCE6B0078 for ; Fri, 26 Feb 2010 10:58:00 -0500 (EST) Date: Fri, 26 Feb 2010 16:57:55 +0100 From: Andi Kleen Subject: Re: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap Message-ID: <20100226155755.GE16335@basil.fritz.box> References: <20100215105253.GE21783@one.firstfloor.org> <20100215110135.GN5723@laptop> <20100220090154.GB11287@basil.fritz.box> <4B862623.5090608@cs.helsinki.fi> <20100226114136.GA16335@basil.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Christoph Lameter Cc: Andi Kleen , David Rientjes , Pekka Enberg , Nick Piggin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, haicheng.li@intel.com, KAMEZAWA Hiroyuki List-ID: On Fri, Feb 26, 2010 at 09:04:56AM -0600, Christoph Lameter wrote: > On Fri, 26 Feb 2010, Andi Kleen wrote: > > > Memory hotplug with node add never quite worked on x86 before, > > for various reasons not related to slab. > > Ok but why did things break in such a big way? 1) numa memory hotadd never worked 2) the rest just bitrotted because nobody tested it. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org