Re: [PATCH][GIT PULL] ftrace: Add function names to dangling } in function graph tracer

From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Tim Bird <tim.bird@am.sony.com>
Subject: Re: [PATCH][GIT PULL] ftrace: Add function names to dangling } in function graph tracer
Date: Sat, 27 Feb 2010 10:43:01 +0100	[thread overview]
Message-ID: <20100227094301.GC31794@elte.hu> (raw)
In-Reply-To: <1267230439.6328.149.camel@gandalf.stny.rr.com>

* Steven Rostedt <rostedt@goodmis.org> wrote:

> 
> Ingo,
> 
> Please pull the latest tip/tracing/core tree, which can be found at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
> tip/tracing/core
> 
> 
> Steven Rostedt (1):
>       ftrace: Add function names to dangling } in function graph tracer
> 
> ----
>  kernel/trace/trace_functions_graph.c |   52 ++++++++++++++++++++++++++++------
>  1 files changed, 43 insertions(+), 9 deletions(-)

Pulled, thanks Steve!

>      [tracing] cat trace
>      # tracer: function_graph
>      #
>      # CPU  DURATION                  FUNCTION CALLS
>      # |     |   |                     |   |   |   |
>       0) + 91.897 us   |                  } (irq_exit)
>       0) ! 567.961 us  |                } (smp_apic_timer_interrupt)
>       0)   <========== |
>       0) ! 579.083 us  |                _raw_spin_lock_irqsave();
>       0)   4.694 us    |                _raw_spin_unlock_irqrestore();
>       0) ! 594.862 us  |              } (add_wait_queue)
>       0) ! 603.361 us  |            } (__pollwait)
>       0) ! 613.574 us  |          } (tcp_poll)
>       0) ! 623.554 us  |        } (sock_poll)
>       0)   3.653 us    |        fget_light();
>       0)               |        sock_poll() {

Neat! I think it would read even more C-ish if it was something non-syntactic, 
like:

>       0) ! 594.862 us  |              } /* add_wait_queue */
>       0) ! 603.361 us  |            } /* __pollwait */
>       0) ! 613.574 us  |          } /* tcp_poll */
>       0) ! 623.554 us  |        } /* sock_poll */

hm?

	Ingo