From: Heiko Voigt <hvoigt@hvoigt.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Markus Heidelberg <markus.heidelberg@web.de>,
"Shawn O. Pearce" <spearce@spearce.org>,
Pat Thoyts <patthoyts@googlemail.com>,
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>,
git@vger.kernel.org,
msysGit Mailinglist <msysgit@googlegroups.com>
Subject: Re: Re: [PATCH] git-gui: fix "Explore Working Copy" for Windows again
Date: Sat, 27 Feb 2010 22:14:30 +0100 [thread overview]
Message-ID: <20100227211428.GF33000@book.hvoigt.net> (raw)
In-Reply-To: <alpine.DEB.1.00.1002260145510.20986@pacific.mpi-cbg.de>
On Fri, Feb 26, 2010 at 01:46:05AM +0100, Johannes Schindelin wrote:
> On Thu, 25 Feb 2010, Heiko Voigt wrote:
>
> > On Thu, Feb 25, 2010 at 01:14:22AM +0100, Markus Heidelberg wrote:
> > > It has already been fixed in commit 454efb47 (git-gui (Win): make
> > > "Explore Working Copy" more robust, 2009-04-01), but has been broken in
> > > commit 21985a11 (git-gui: handle non-standard worktree locations,
> > > 2010-01-23) by accidentally replacing too much with a new variable.
> > >
> > > The problem can be reproduced when starting git-gui from within a
> > > subdirectory. The solution is to convert the path name, explorer.exe is
> > > invoked with, to a platform native name.
> > >
> > > Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
> > > ---
> >
> > I can confirm that this does fix the issue which is actually also
> > apparent on Windows XP. If no objections occur I would apply this to the
> > devel branch for msysgit.
>
> No objections from my side!
Done.
cheers Heiko
next prev parent reply other threads:[~2010-02-27 21:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 22:52 [GIT GUI PATCH] git-gui: fix open explorer window on Windows 7 Heiko Voigt
2010-02-24 0:14 ` Markus Heidelberg
2010-02-24 6:22 ` Giuseppe Bilotta
2010-02-24 12:12 ` [msysGit] " Pat Thoyts
2010-02-25 0:14 ` [PATCH] git-gui: fix "Explore Working Copy" for Windows again Markus Heidelberg
2010-02-25 20:44 ` Heiko Voigt
2010-02-25 23:00 ` Pat Thoyts
2010-02-26 0:46 ` Johannes Schindelin
2010-02-27 21:14 ` Heiko Voigt [this message]
2010-02-24 12:15 ` [msysGit] [GIT GUI PATCH] git-gui: fix open explorer window on Windows 7 Pat Thoyts
2010-02-25 20:30 ` Heiko Voigt
2010-02-25 22:23 ` [msysGit] " Markus Heidelberg
2010-02-25 22:49 ` Pat Thoyts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100227211428.GF33000@book.hvoigt.net \
--to=hvoigt@hvoigt.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
--cc=markus.heidelberg@web.de \
--cc=msysgit@googlegroups.com \
--cc=patthoyts@googlemail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.