All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <florian@openwrt.org>
To: Yang Shi <yang.shi@windriver.com>
Cc: ddaney@caviumnetworks.com, ralf@linux-mips.org,
	linux-mips@linux-mips.org
Subject: Re: [PATCH 3/3] MIPS: Octeon: Add add_wired_entry decralation in header file
Date: Wed, 3 Mar 2010 09:19:35 +0100	[thread overview]
Message-ID: <201003030919.36006.florian@openwrt.org> (raw)
In-Reply-To: <9e4e80f8edd43f8a164fe618c978c1dc8cd48a69.1267600234.git.yang.shi@windriver.com>

Hi Yang,

On Wednesday 03 March 2010 08:26:12 Yang Shi wrote:
> Octeon's setup.c uses add_wired_entry, but it is not declared
> anywhere. Copy add_wired_entry decralation fomr pgtable-32.h to
> pgtable-64.h and include asm/pgtable.h into Octeon's setup.c.
> 
> Signed-off-by: Yang Shi <yang.shi@windriver.com>
> ---
>  arch/mips/cavium-octeon/setup.c    |    1 +
>  arch/mips/include/asm/pgtable-64.h |    6 ++++++
>  2 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/mips/cavium-octeon/setup.c
>  b/arch/mips/cavium-octeon/setup.c index 8309d68..f35ba16 100644
> --- a/arch/mips/cavium-octeon/setup.c
> +++ b/arch/mips/cavium-octeon/setup.c
> @@ -30,6 +30,7 @@
>  #include <asm/bootinfo.h>
>  #include <asm/sections.h>
>  #include <asm/time.h>
> +#include <asm/pagtable.h>

You probably meant to include <asm/pgtable.h> instead.

> 
>  #include <asm/octeon/octeon.h>
> 
> diff --git a/arch/mips/include/asm/pgtable-64.h
>  b/arch/mips/include/asm/pgtable-64.h index 26dc69d..85ee34d 100644
> --- a/arch/mips/include/asm/pgtable-64.h
> +++ b/arch/mips/include/asm/pgtable-64.h
> @@ -23,6 +23,12 @@
>  #endif
> 
>  /*
> + * - add_wired_entry() add a fixed TLB entry, and move wired register
> + */
> +extern void add_wired_entry(unsigned long entrylo0, unsigned long
>  entrylo1, +			       unsigned long entryhi, unsigned long pagemask);
> +
> +/*
>   * Each address space has 2 4K pages as its page directory, giving 1024
>   * (== PTRS_PER_PGD) 8 byte pointers to pmd tables. Each pmd table is a
>   * single 4K page, giving 512 (== PTRS_PER_PMD) 8 byte pointers to page
> 

-- 
Regards, Florian

  reply	other threads:[~2010-03-03  8:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-03  7:26 Octeon: Several misc fixes Yang Shi
2010-03-03  7:26 ` [PATCH 1/3] MIPS: Octeon: Remove superfluous on_each_cpu parameter Yang Shi
2010-03-03  7:26   ` [PATCH 2/3] MIPS: Octeon: Remove redundant declaration of octeon_reserve32_memory Yang Shi
2010-03-03  7:26     ` [PATCH 3/3] MIPS: Octeon: Add add_wired_entry decralation in header file Yang Shi
2010-03-03  8:19       ` Florian Fainelli [this message]
2010-03-03  8:25         ` Yang Shi
2010-03-03  8:43 [V2] Octeon: Several misc fixes Yang Shi
2010-03-03  8:43 ` [PATCH 1/3] MIPS: Octeon: Remove superfluous on_each_cpu parameter Yang Shi
2010-03-03  8:43   ` [PATCH 2/3] MIPS: Octeon: Remove redundant declaration of octeon_reserve32_memory Yang Shi
2010-03-03  8:43     ` [PATCH 3/3] MIPS: Octeon: Add add_wired_entry decralation in header file Yang Shi
2010-03-03 18:24       ` David Daney
2010-03-09 14:16         ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201003030919.36006.florian@openwrt.org \
    --to=florian@openwrt.org \
    --cc=ddaney@caviumnetworks.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=yang.shi@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.