From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754704Ab0CCOe7 (ORCPT ); Wed, 3 Mar 2010 09:34:59 -0500 Received: from one.firstfloor.org ([213.235.205.2]:44507 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754188Ab0CCOe6 (ORCPT ); Wed, 3 Mar 2010 09:34:58 -0500 Date: Wed, 3 Mar 2010 15:34:50 +0100 From: Andi Kleen To: Pekka Enberg Cc: Andi Kleen , David Rientjes , Nick Piggin , Christoph Lameter , linux-kernel@vger.kernel.org, linux-mm@kvack.org, haicheng.li@intel.com, KAMEZAWA Hiroyuki Subject: Re: [patch] slab: add memory hotplug support Message-ID: <20100303143450.GA25500@basil.fritz.box> References: <20100226114136.GA16335@basil.fritz.box> <20100226155755.GE16335@basil.fritz.box> <20100302125306.GD19208@basil.fritz.box> <84144f021003020704s3abafc24t9b8ab34234094b79@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <84144f021003020704s3abafc24t9b8ab34234094b79@mail.gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > The patch looks far more complicated than my simple fix. > > I wouldn't exactly call the fallback_alloc() games "simple". I have to disagree on that. It was the most simple fix I could come up with, least intrusive to legacy like slab is. > > Is more complicated now better? > > Heh, heh. You can't post the oops, you don't want to rework your The missing oops was about the timer race, not about this one. > patches as per review comments, and now you complain about David's > patch without one bit of technical content. I'm sorry but I must Well sorry I'm just a bit frustrated about the glacial progress on what should be relatively straight forward fixes. IMHO something like my patch should have gone into .33 and any more complicated reworks like this into .34. > But anyway, if you have real technical concerns over the patch, please > make them known; otherwise I'd much appreciate a Tested-by tag from > you for David's patch. If it works it would be ok for me. The main concern would be to actually get it fixed. -Andi -- ak@linux.intel.com -- Speaking for myself only. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id 472A46B0047 for ; Wed, 3 Mar 2010 09:34:55 -0500 (EST) Date: Wed, 3 Mar 2010 15:34:50 +0100 From: Andi Kleen Subject: Re: [patch] slab: add memory hotplug support Message-ID: <20100303143450.GA25500@basil.fritz.box> References: <20100226114136.GA16335@basil.fritz.box> <20100226155755.GE16335@basil.fritz.box> <20100302125306.GD19208@basil.fritz.box> <84144f021003020704s3abafc24t9b8ab34234094b79@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <84144f021003020704s3abafc24t9b8ab34234094b79@mail.gmail.com> Sender: owner-linux-mm@kvack.org To: Pekka Enberg Cc: Andi Kleen , David Rientjes , Nick Piggin , Christoph Lameter , linux-kernel@vger.kernel.org, linux-mm@kvack.org, haicheng.li@intel.com, KAMEZAWA Hiroyuki List-ID: > > The patch looks far more complicated than my simple fix. > > I wouldn't exactly call the fallback_alloc() games "simple". I have to disagree on that. It was the most simple fix I could come up with, least intrusive to legacy like slab is. > > Is more complicated now better? > > Heh, heh. You can't post the oops, you don't want to rework your The missing oops was about the timer race, not about this one. > patches as per review comments, and now you complain about David's > patch without one bit of technical content. I'm sorry but I must Well sorry I'm just a bit frustrated about the glacial progress on what should be relatively straight forward fixes. IMHO something like my patch should have gone into .33 and any more complicated reworks like this into .34. > But anyway, if you have real technical concerns over the patch, please > make them known; otherwise I'd much appreciate a Tested-by tag from > you for David's patch. If it works it would be ok for me. The main concern would be to actually get it fixed. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org