From: Dave Chinner <david@fromorbit.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Alex Elder <aelder@sgi.com>,
xfs-masters@oss.sgi.com
Subject: Re: [PATCH mmotm] xfs: needs LIST_SORT
Date: Thu, 4 Mar 2010 10:25:22 +1100 [thread overview]
Message-ID: <20100303232522.GC14317@discord.disaster> (raw)
In-Reply-To: <4B8EB545.8060806@oracle.com>
On Wed, Mar 03, 2010 at 11:15:17AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> xfs uses list_sort (library function), so it needs to select it.
> Fixes these build errors:
> fs/xfs/linux-2.6/xfs_buf.c:1918: undefined reference to `list_sort'
> fs/xfs/linux-2.6/xfs_buf.c:1996: undefined reference to `list_sort'
> fs/xfs/linux-2.6/xfs_buf.c:1950: undefined reference to `list_sort'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> fs/xfs/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- mmotm-2010-0302-1838.orig/fs/xfs/Kconfig
> +++ mmotm-2010-0302-1838/fs/xfs/Kconfig
> @@ -2,6 +2,7 @@ config XFS_FS
> tristate "XFS filesystem support"
> depends on BLOCK
> select EXPORTFS
> + select LIST_SORT
> help
> XFS is a high performance journaling filesystem which originated
> on the SGI IRIX platform. It is completely multi-threaded, can
Looks OK, but when and why did a config option get introduced for
this? I thought that Andi was trying to cull unused symbols in
library functions automatically, so config options weren't needed...
FWIW, did UBIFS and DRM also get this select line added to them?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2010-03-03 23:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 2:39 mmotm 2010-03-02-18-38 uploaded akpm
2010-03-03 6:40 ` KAMEZAWA Hiroyuki
2010-03-03 18:09 ` mmotm 2010-03-02 - kernel BUG at fs/direct-io.c:630 Valdis.Kletnieks
2010-03-03 18:55 ` Dmitry Monakhov
2010-03-03 19:55 ` Valdis.Kletnieks
2010-03-03 19:15 ` [PATCH mmotm] xfs: needs LIST_SORT Randy Dunlap
2010-03-03 23:25 ` Dave Chinner [this message]
2010-03-03 23:35 ` Randy Dunlap
2010-03-04 0:31 ` Dave Chinner
2010-03-03 19:19 ` mmotm 2010-03-02-18-38 uploaded (dma unmapping) Randy Dunlap
2010-03-03 23:08 ` FUJITA Tomonori
2010-03-03 23:20 ` Randy Dunlap
2010-03-04 1:22 ` FUJITA Tomonori
2010-03-04 2:29 ` Randy Dunlap
2010-03-04 14:54 ` mmotm 2010-03-02-18-38 uploaded Jiri Slaby
2010-03-04 15:05 ` no boot with NO_BOOTMEM=y [was: mmotm 2010-03-02-18-38 uploaded] Jiri Slaby
2010-03-04 19:28 ` Yinghai Lu
2010-03-05 0:29 ` Yinghai Lu
2010-03-05 10:09 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100303232522.GC14317@discord.disaster \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=xfs-masters@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.