All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Michael J Gruber <git@drmicha.warpmail.net>
Subject: Re: [PATCHv2 0/2] Make t9119-git-svn-info.sh run with svn 1.6.*
Date: Thu, 4 Mar 2010 01:47:08 -0800	[thread overview]
Message-ID: <20100304094708.GA12885@dcvr.yhbt.net> (raw)
In-Reply-To: <cover.1267647872.git.git@drmicha.warpmail.net>

Michael J Gruber <git@drmicha.warpmail.net> wrote:
> I'm sorry my previous analysis was wrong. In fact, since the delayed
> loading of SVN::Core, git-svn's cmd_info would guess the wrong svn version
> because it uses SVN::Core without loading it (leading to an empty version string).
> 
> After fixing this, the test runs unmodified, so enbale it for 1.6.*.
> 
> Michael J Gruber (2):
>   git-svn: req_svn when needed
>   t9119-git-svn-info.sh: test with svn 1.6.* as well
> 
>  git-svn.perl            |    1 +
>  t/t9119-git-svn-info.sh |    3 ++-
>  2 files changed, 3 insertions(+), 1 deletions(-)

Thanks Michael,

Acked and pushed out to: git://git.bogomips.org/git-svn.git

-- 
Eric Wong

      parent reply	other threads:[~2010-03-04  9:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-03 17:08 [PATCH] t9119-git-svn-info.sh: test with svn 1.6.* as well Michael J Gruber
2010-03-03 20:34 ` [PATCHv2 0/2] Make t9119-git-svn-info.sh run with svn 1.6.* Michael J Gruber
2010-03-03 20:34   ` [PATCHv2 1/2] git-svn: req_svn when needed Michael J Gruber
2010-03-03 20:34   ` [PATCHv2 2/2] t9119-git-svn-info.sh: test with svn 1.6.* as well Michael J Gruber
2010-03-04  9:47   ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100304094708.GA12885@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.