From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NnA5M-0001aK-KZ
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 07:23:24 -0500
Received: from [199.232.76.173] (port=57831 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NnA5M-0001Zw-5F
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 07:23:24 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <mst@redhat.com>) id 1NnA5K-0005Uk-W8
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 07:23:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:32064)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NnA5K-0005Ua-Kh
	for qemu-devel@nongnu.org; Thu, 04 Mar 2010 07:23:22 -0500
Date: Thu, 4 Mar 2010 14:19:58 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv4 07/12] virtio: move typedef to qemu-common
Message-ID: <20100304121958.GA3047@redhat.com>
References: <cover.1267636215.git.mst@redhat.com>
	<9075331a15707f770788ed361f2228b88bb7a7c5.1267636215.git.mst@redhat.com>
	<20100304122019.GC8118@amit-x200.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100304122019.GC8118@amit-x200.redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: quintela@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com

On Thu, Mar 04, 2010 at 05:50:19PM +0530, Amit Shah wrote:
> On (Wed) Mar 03 2010 [19:16:28], Michael S. Tsirkin wrote:
> > make it possible to use type without header include
> 
> Why?

So that vhost.h does not need to include virtio.h

> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  hw/virtio.h   |    1 -
> >  qemu-common.h |    1 +
> >  2 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/hw/virtio.h b/hw/virtio.h
> > index 58b06bf..6f2fab0 100644
> > --- a/hw/virtio.h
> > +++ b/hw/virtio.h
> > @@ -69,7 +69,6 @@ static inline target_phys_addr_t vring_align(target_phys_addr_t addr,
> >  }
> >  
> >  typedef struct VirtQueue VirtQueue;
> > -typedef struct VirtIODevice VirtIODevice;
> >  
> >  #define VIRTQUEUE_MAX_SIZE 1024
> >  
> > diff --git a/qemu-common.h b/qemu-common.h
> > index f12a8f5..90ca3b8 100644
> > --- a/qemu-common.h
> > +++ b/qemu-common.h
> > @@ -228,6 +228,7 @@ typedef struct I2SCodec I2SCodec;
> >  typedef struct DeviceState DeviceState;
> >  typedef struct SSIBus SSIBus;
> >  typedef struct EventNotifier EventNotifier;
> > +typedef struct VirtIODevice VirtIODevice;
> >  
> >  typedef uint64_t pcibus_t;
> 
> 		Amit