From mboxrd@z Thu Jan  1 00:00:00 1970
From: Glauber Costa <glommer@redhat.com>
Subject: Re: [PATCH 08/10] Add -kvm option
Date: Thu, 4 Mar 2010 16:39:20 -0300
Message-ID: <20100304193920.GK665@mothafucka.localdomain>
References: <1267215141-13629-2-git-send-email-glommer@redhat.com>
 <1267215141-13629-3-git-send-email-glommer@redhat.com>
 <1267215141-13629-4-git-send-email-glommer@redhat.com>
 <1267215141-13629-5-git-send-email-glommer@redhat.com>
 <1267215141-13629-6-git-send-email-glommer@redhat.com>
 <1267215141-13629-7-git-send-email-glommer@redhat.com>
 <1267215141-13629-8-git-send-email-glommer@redhat.com>
 <1267215141-13629-9-git-send-email-glommer@redhat.com>
 <4B88F55A.6040702@web.de>
 <4B8FDDC6.3010205@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, mtosatti@redhat.com
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:29906 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756225Ab0CDTjZ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 4 Mar 2010 14:39:25 -0500
Content-Disposition: inline
In-Reply-To: <4B8FDDC6.3010205@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Mar 04, 2010 at 05:20:22PM +0100, Jan Kiszka wrote:
> Jan Kiszka wrote:
> > Glauber Costa wrote:
> >> This option deprecates --enable-kvm. It is a more flexible option,
> >> that makes use of qemu-opts, and allow us to pass on options to enable or
> >> disable kernel irqchip, for example.
> >>
> > 
> > ...
> > 
> >> diff --git a/qemu-options.hx b/qemu-options.hx
> >> index 3f49b44..f8fd86d 100644
> >> --- a/qemu-options.hx
> >> +++ b/qemu-options.hx
> >> @@ -1793,10 +1793,17 @@ Set the filename for the BIOS.
> >>  ETEXI
> >>  
> >>  #ifdef CONFIG_KVM
> >> -DEF("enable-kvm", 0, QEMU_OPTION_enable_kvm, \
> >> -    "-enable-kvm     enable KVM full virtualization support\n")
> >> +HXCOMM Options deprecated by -kvm
> >> +DEF("enable-kvm", 0, QEMU_OPTION_enable_kvm, "")
> >> +
> >> +DEF("kvm", HAS_ARG, QEMU_OPTION_kvm, \
> >> +    "-kvm enable=on|off,irqchip-in-kernel=on|off\n" \
> >> +    "                enable KVM full virtualization support\n")
> >> +
> 
> Argh, never trust documentation: The magic option is "enabled", not
> "enable". :)
> 
> > 
> > I would prefer "irqchip=kernel|user" - shorter and even more verbose.
> 
> And we should refuse to work if the user tries to enable in-kernel
> support without having io-threads enabled. That obviously fails silently
> so far.
> 
> "info kvm" should also be extended to report the configuration in force.
I am waiting for marcelo to apply your patches (if he hasn't done already), then
I'll redo this. Agreed with this point, so plan on changing.

> 
> > 
> > Forgot if that was discussed already: Do we want "pit=kernel|user" as well?
> > 
> 
I guess we do.