All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Len Brown <lenb@kernel.org>,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI / PM: Move ACPI video resume to a PM notifier
Date: Thu, 4 Mar 2010 20:12:36 +0100	[thread overview]
Message-ID: <201003042012.36416.rjw@sisk.pl> (raw)
In-Reply-To: <b170af451003040311g3cea44caj1cd0e23e55814696@mail.gmail.com>

On Thursday 04 March 2010, Rafał Miłecki wrote:
> 2010/3/4 Rafael J. Wysocki <rjw@sisk.pl>:
> > There is a problem with the ACPI video resume routine that it's
> > executed before the GPU that may be accessed by it.  To fix this
> > issue, move the ACPI video resume to a power management notifier,
> > so that it's executed after resuming all devices, including the GPU.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > ---
> 
> Tested-by: Rafał Miłecki <zajec5@gmail.com>

Thanks!

> It partially fixes bugzilla bug #15096 and it first needed step to fix
> it completely.

To fix that completely we'd need to avoid calling acpi_video_resume() in the
non-KMS case, but it's not clear how to tell the ACPI driver which case we're
in.  It's not certain how to reliably distinguish the KMS and non-KMS cases at
this level in the first place.

> Can we send this to stable for .32 and .33?

That depends on Len.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Len Brown <lenb@kernel.org>,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPI / PM: Move ACPI video resume to a PM notifier
Date: Thu, 4 Mar 2010 20:12:36 +0100	[thread overview]
Message-ID: <201003042012.36416.rjw@sisk.pl> (raw)
In-Reply-To: <b170af451003040311g3cea44caj1cd0e23e55814696@mail.gmail.com>

On Thursday 04 March 2010, Rafał Miłecki wrote:
> 2010/3/4 Rafael J. Wysocki <rjw@sisk.pl>:
> > There is a problem with the ACPI video resume routine that it's
> > executed before the GPU that may be accessed by it.  To fix this
> > issue, move the ACPI video resume to a power management notifier,
> > so that it's executed after resuming all devices, including the GPU.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > ---
> 
> Tested-by: Rafał Miłecki <zajec5@gmail.com>

Thanks!

> It partially fixes bugzilla bug #15096 and it first needed step to fix
> it completely.

To fix that completely we'd need to avoid calling acpi_video_resume() in the
non-KMS case, but it's not clear how to tell the ACPI driver which case we're
in.  It's not certain how to reliably distinguish the KMS and non-KMS cases at
this level in the first place.

> Can we send this to stable for .32 and .33?

That depends on Len.

Rafael

  parent reply	other threads:[~2010-03-04 19:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-04  0:25 [PATCH] ACPI / PM: Move ACPI video resume to a PM notifier Rafael J. Wysocki
2010-03-04  0:24 ` Matthew Garrett
2010-03-04  0:24 ` Matthew Garrett
2010-03-04 11:11 ` Rafał Miłecki
2010-03-04 11:11   ` Rafał Miłecki
2010-03-04 19:12   ` Rafael J. Wysocki
2010-03-04 19:12   ` Rafael J. Wysocki [this message]
2010-03-04 19:12     ` Rafael J. Wysocki
2010-03-12 21:25     ` Rafał Miłecki
2010-03-12 21:25       ` Rafał Miłecki
2010-03-17 21:36       ` Len Brown
2010-03-17 21:36         ` Len Brown
2010-03-12 21:25     ` Rafał Miłecki
2010-03-04 11:11 ` Rafał Miłecki
2010-04-04 23:43 ` Rafael J. Wysocki
2010-04-04 23:43 ` Rafael J. Wysocki
2010-03-04  0:25 Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201003042012.36416.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.