From: Aurelien Jarno <aurelien@aurel32.net>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] Re: [RESEND][PATCH][STABLE] Fix corner case in chardev udp: parameter
Date: Sat, 13 Mar 2010 12:05:41 +0100 [thread overview]
Message-ID: <20100313110541.GD26216@hall.aurel32.net> (raw)
In-Reply-To: <4B952975.6000605@codemonkey.ws>
On Mon, Mar 08, 2010 at 10:44:37AM -0600, Anthony Liguori wrote:
> On 03/07/2010 04:28 AM, Jan Kiszka wrote:
>> The missing '@' broke 'udp::<port>@:<port>' parsing.
>>
>> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>>
>
> Applied to stable, thanks.
The same problem exists in HEAD. Shouldn't it be applied here too?
>
> Regards,
>
> Anthony Liguori
>
>> ---
>> qemu-char.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/qemu-char.c b/qemu-char.c
>> index 86c7c5a..0d8553d 100644
>> --- a/qemu-char.c
>> +++ b/qemu-char.c
>> @@ -2333,7 +2333,7 @@ QemuOpts *qemu_chr_parse_compat(const char *label, const char *filename)
>> qemu_opt_set(opts, "backend", "udp");
>> if (sscanf(p, "%64[^:]:%32[^@,]%n", host, port,&pos)< 2) {
>> host[0] = 0;
>> - if (sscanf(p, ":%32[^,]%n", port,&pos)< 1) {
>> + if (sscanf(p, ":%32[^@,]%n", port,&pos)< 1) {
>> goto fail;
>> }
>> }
>>
>>
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2010-03-13 11:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-07 10:28 [Qemu-devel] [RESEND][PATCH][STABLE] Fix corner case in chardev udp: parameter Jan Kiszka
2010-03-08 16:44 ` [Qemu-devel] " Anthony Liguori
2010-03-13 11:05 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100313110541.GD26216@hall.aurel32.net \
--to=aurelien@aurel32.net \
--cc=aliguori@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=jan.kiszka@siemens.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.