All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shaohua Li <shaohua.li@intel.com>
To: linux-kernel@vger.kernel.org
Cc: jens.axboe@oracle.com, czoccolo@gmail.com, vgoyal@redhat.com,
	jmoyer@redhat.com, guijianfeng@cn.fujitsu.com,
	alex.shi@intel.com, shaohua.li@intel.com
Subject: [RFC]cfq-iosched: fix a kbuild regression
Date: Tue, 16 Mar 2010 10:56:56 +0800	[thread overview]
Message-ID: <20100316025656.GA15390@sli10-desk.sh.intel.com> (raw)

Alex Shi reported a kbuild regression which is about 10% performance lost.
He bisected to this commit: 3dde36ddea3e07dd025c4c1ba47edec91606fec0.
The reason is cfqq_close() can't find close cooperator. If we store the seek
distance to the value before the commit like below, the regression fully goes
away. If this is too invasive, just changing the cfq_rq_close() for the
!for_preempt is ok too.

Reported-by: Alex Shi <alex.shi@intel.com>
Signed-off-by: Shaohua Li <shaohua.li@intel.com>

diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index dee9d93..fcae456 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -46,7 +46,7 @@ static const int cfq_hist_divisor = 4;
 #define CFQ_HW_QUEUE_MIN	(5)
 #define CFQ_SERVICE_SHIFT       12
 
-#define CFQQ_SEEK_THR		(sector_t)(8 * 100)
+#define CFQQ_SEEK_THR		(sector_t)(8 * 1024)
 #define CFQQ_SECT_THR_NONROT	(sector_t)(2 * 32)
 #define CFQQ_SEEKY(cfqq)	(hweight32(cfqq->seek_history) > 32/8)
 

             reply	other threads:[~2010-03-16  2:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-16  2:56 Shaohua Li [this message]
2010-03-17 13:30 ` [RFC]cfq-iosched: fix a kbuild regression Jens Axboe
2010-03-17 18:24   ` Corrado Zoccolo
2010-03-18  1:05     ` Shaohua Li
2010-03-18 16:55       ` Corrado Zoccolo
2010-03-19  7:57       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100316025656.GA15390@sli10-desk.sh.intel.com \
    --to=shaohua.li@intel.com \
    --cc=alex.shi@intel.com \
    --cc=czoccolo@gmail.com \
    --cc=guijianfeng@cn.fujitsu.com \
    --cc=jens.axboe@oracle.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.