From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ns9SL-0000J8-OC
	for qemu-devel@nongnu.org; Thu, 18 Mar 2010 02:43:45 -0400
Received: from [199.232.76.173] (port=53217 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ns9SL-0000I1-0t
	for qemu-devel@nongnu.org; Thu, 18 Mar 2010 02:43:45 -0400
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <mst@redhat.com>) id 1Ns9SJ-0001f0-Nl
	for qemu-devel@nongnu.org; Thu, 18 Mar 2010 02:43:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39966)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1Ns9SJ-0001ev-BW
	for qemu-devel@nongnu.org; Thu, 18 Mar 2010 02:43:43 -0400
Received: from int-mx03.intmail.prod.int.phx2.redhat.com
	(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2I6he8v020548
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 18 Mar 2010 02:43:41 -0400
Date: Thu, 18 Mar 2010 08:40:15 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100318064015.GA16973@redhat.com>
References: <cover.1268765204.git.quintela@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1268765204.git.quintela@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On Tue, Mar 16, 2010 at 07:51:16PM +0100, Juan Quintela wrote:
> Hi
> 
> This series introduces several virtio cleanups:
> - add comment to pci (mst)
> - tell virtio about DO_UPCAST

I think we should move away from struct layout assumptions that
DO_UPCAST enforces, and to use container_of where possible.
I'll post a series shortly that do this for virtio.

> - use QLIST instead of one open list
> - virtio-pci/msix: remove duplicated test
> 
> Please review and apply.
> 
> This is split for a series previously sent.  Will send the vmstate
> conversions as a different series on top of this one.
> 
> Later, Juan.
> 
> Juan Quintela (8):
>   virtio: Teach virtio-balloon about DO_UPCAST
>   virtio: Teach virtio-blk about DO_UPCAST
>   virtio: Teach virtio-net about DO_UPCAST
>   virtio: Use DO_UPCAST instead of a cast
>   virtio-pci: Remove duplicate test
>   QLIST: Introduce QLIST_COPY_HEAD
>   virtio-blk: change rq type to VirtIOBlockReq
>   virtio-blk: use QLIST for the list of requests
> 
> Michael S. Tsirkin (1):
>   qemu/pci: document msix_entries_nr field
> 
>  hw/msix.c           |    8 -------
>  hw/pci.h            |    4 ++-
>  hw/virtio-balloon.c |   15 ++++---------
>  hw/virtio-blk.c     |   54 ++++++++++++++++++++++++--------------------------
>  hw/virtio-net.c     |   29 +++++++++++----------------
>  hw/virtio-pci.c     |    7 +++--
>  qemu-queue.h        |    4 +++
>  7 files changed, 54 insertions(+), 67 deletions(-)
> 
>