From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NsBR7-0005us-2v
	for qemu-devel@nongnu.org; Thu, 18 Mar 2010 04:50:37 -0400
Received: from [199.232.76.173] (port=33017 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NsBR6-0005ty-24
	for qemu-devel@nongnu.org; Thu, 18 Mar 2010 04:50:36 -0400
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <mst@redhat.com>) id 1NsBR4-0000DE-SJ
	for qemu-devel@nongnu.org; Thu, 18 Mar 2010 04:50:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49733)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NsBR4-0000D6-FH
	for qemu-devel@nongnu.org; Thu, 18 Mar 2010 04:50:34 -0400
Received: from int-mx05.intmail.prod.int.phx2.redhat.com
	(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2I8oXn2014233
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 18 Mar 2010 04:50:33 -0400
Date: Thu, 18 Mar 2010 10:47:08 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100318084707.GA23649@redhat.com>
References: <cover.1268765204.git.quintela@redhat.com>
	<ed1cba97c3c9582c918d70de4d18734c70ffe748.1268765204.git.quintela@redhat.com>
	<20100318072529.GB16973@redhat.com> <m37hpanihp.fsf@trasno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m37hpanihp.fsf@trasno.mitica>
Subject: [Qemu-devel] Re: [PATCH 6/9] virtio-pci: Remove duplicate test
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, Mar 18, 2010 at 09:26:10AM +0100, Juan Quintela wrote:
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > On Tue, Mar 16, 2010 at 07:51:22PM +0100, Juan Quintela wrote:
> >> We already do the test for msix on the caller, just use that test
> >> 
> >> Signed-off-by: Juan Quintela <quintela@redhat.com>
> >
> > NAK
> >
> > I think we are better off not making assumptions
> > about caller behaviour in msix.c, virtio
> > will not be the only user forever.
> 
> That makes migration testing more difficult.  Basically we are testing
> if we are using msix in two places.  Obvious thing is:
> - we don't test in msix_save() if msix is used.
> - we don't test it in virtio_pci_save_config()
> 
> I don't care if it is one way or another, but requiring to check it in
> the caller and the callee is a bit too much for me.
> 
> Later, Juan.

msix does not require the check in the caller, by design it is
safe to call msix_save when msix is not present.

-- 
MST