From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sfi-mx-1.v28.ch3.sourceforge.com ([172.29.28.121] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1NsH8A-00011t-V1 for ltp-list@lists.sourceforge.net; Thu, 18 Mar 2010 14:55:26 +0000 Received: from e7.ny.us.ibm.com ([32.97.182.137]) by sfi-mx-1.v28.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) id 1NsH89-0003pe-TD for ltp-list@lists.sourceforge.net; Thu, 18 Mar 2010 14:55:26 +0000 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by e7.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id o2IEkueE026933 for ; Thu, 18 Mar 2010 10:46:56 -0400 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o2IEtJZp126690 for ; Thu, 18 Mar 2010 10:55:19 -0400 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o2IEt6XW028839 for ; Thu, 18 Mar 2010 08:55:06 -0600 Date: Thu, 18 Mar 2010 09:55:05 -0500 From: "Serge E. Hallyn" Message-ID: <20100318145505.GC6287@us.ibm.com> References: <20100302152135.GA6691@us.ibm.com> <20100302173535.GA14556@us.ibm.com> <5EEDD2C4-6C6C-4008-81AA-65B78FA3E7C8@gmail.com> <20100303055619.GA19084@linux.vnet.ibm.com> <364299f41003030114x30e251d6x7cd7993f8f75792f@mail.gmail.com> <20100318092516.GA16328@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100318092516.GA16328@linux.vnet.ibm.com> Subject: Re: [LTP] LTP's filecaps test gives false positive results List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Garrett Cooper , Rishikesh K Rajak , Iranna D Ankad , "ltp-list@lists.sourceforge.net" Quoting Rishikesh K Rajak (risrajak@linux.vnet.ibm.com): > On Wed, Mar 03, 2010 at 01:14:12AM -0800, Garrett Cooper wrote: > > Yes -- and I think this is because the constants no longer have > > the same name: > > > > http://fxr.watson.org/fxr/source/include/linux/prctl.h?v=linux-2.6#L68 > > > > Note -- CAP_BSET_DROP should be: PR_CAPBSET_DROP, etc. > > > > Which is why I stress _not_ putting these hardcoded constants in > > test files (POLLHDRDUP -- or whatever it was in ppoll01 -- is the only > > real violation I can remember OTOH that I need to clean up > > eventually). We need to be consistent with any and all documentation > > provided to end-developers or we [LTP] are going to shoot ourselves in > > the foot if and when the underlying functionality changes. > > I'll update the tests this weekend, but I would like it if someone > > test the tests on an outdated distro (RHEL 4.x?) once I provide a > > Hi Garret, > > Can you please look this again ? Wait, what? Was the original complaint just about a #warning? Note that it will #warn but then go ahead and define it, so there should not be a real problem. Anyway I'll try to get time tomorrow to rewrite this to use the constants from the new securebits.h (which may not be in sys/ yet, but is in linux/ atm and will show up under sys/ at some point). If Garret could help me with doing an automate thingamagiggy to detect whether prctl(CAP_BSET_DROP) returns -ENOSYS and not compile/install/run the tests in that case, that'd be great. And maybe I'll finally implement some of the new securebits testcases I spelled out a year or two ago. thanks, -serge ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list