From: snitzer@sourceware.org <snitzer@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW tools/lvresize.c
Date: 20 Mar 2010 03:44:04 -0000 [thread overview]
Message-ID: <20100320034404.3220.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: snitzer at sourceware.org 2010-03-20 03:44:04
Modified files:
. : WHATS_NEW
tools : lvresize.c
Log message:
Don't allow resizing of internal logical volumes.
Prevent lvresize from being able to resize internal LVs: mirror legs
(*_mimage_*), mirror log (*_mlog), snapshot placeholder LVs (snapshot*)
and others. Resizing these would leads to unexpected metadata and
sometimes crashes (in case of growing snapshot*).
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1471&r2=1.1472
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvresize.c.diff?cvsroot=lvm2&r1=1.119&r2=1.120
--- LVM2/WHATS_NEW 2010/03/19 18:33:55 1.1471
+++ LVM2/WHATS_NEW 2010/03/20 03:44:04 1.1472
@@ -1,5 +1,6 @@
Version 2.02.63 -
================================
+ Don't allow resizing of internal logical volumes.
Fix libdevmapper-event pkgconfig version string to match libdevmapper.
Avoid scanning all pvs in the system if operating on a device with mdas.
Add configure --with-clvmd=singlenode to use clvmd w/o cluster infrastructure.
--- LVM2/tools/lvresize.c 2010/02/03 03:58:08 1.119
+++ LVM2/tools/lvresize.c 2010/03/20 03:44:04 1.120
@@ -323,6 +323,11 @@
lv = lvl->lv;
+ if (!lv_is_visible(lv)) {
+ log_error("Can't resize internal logical volume %s", lv->name);
+ return ECMD_FAILED;
+ }
+
if (lv->status & LOCKED) {
log_error("Can't resize locked LV %s", lv->name);
return ECMD_FAILED;
next reply other threads:[~2010-03-20 3:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 3:44 snitzer [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-11 12:40 LVM2 ./WHATS_NEW tools/lvresize.c zkabelac
2012-04-11 12:36 zkabelac
2012-02-08 10:56 zkabelac
2012-01-09 12:31 zkabelac
2011-12-01 0:13 jbrassow
2009-01-15 14:44 wysochanski
2008-09-18 18:51 agk
2008-04-01 22:15 wysochanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100320034404.3220.qmail@sourceware.org \
--to=snitzer@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.