* [PATCH] ksz884x: fix return value of netdev_set_eeprom
@ 2010-03-23 14:23 Jens Rottmann
2010-03-23 20:09 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jens Rottmann @ 2010-03-23 14:23 UTC (permalink / raw)
To: David S. Miller; +Cc: Tristram Ha, netdev, linux-kernel
ksz884x: fix return value of netdev_set_eeprom
netdev_set_eeprom() confused ethtool by just returning 1 on error
instead of a proper -EINVAL.
Signed-off-by: Jens Rottmann <JRottmann@LiPPERTEmbedded.de>
---
--- linux-2.6.34-rc2-git1/drivers/net/ksz884x.c
+++ return_value_fixed/drivers/net/ksz884x.c
@@ -6322,7 +6322,7 @@ static int netdev_set_eeprom(struct net_
int len;
if (eeprom->magic != EEPROM_MAGIC)
- return 1;
+ return -EINVAL;
len = (eeprom->offset + eeprom->len + 1) / 2;
for (i = eeprom->offset / 2; i < len; i++)
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ksz884x: fix return value of netdev_set_eeprom
2010-03-23 14:23 [PATCH] ksz884x: fix return value of netdev_set_eeprom Jens Rottmann
@ 2010-03-23 20:09 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-03-23 20:09 UTC (permalink / raw)
To: JRottmann; +Cc: Tristram.Ha, netdev, linux-kernel
From: Jens Rottmann <JRottmann@LiPPERTEmbedded.de>
Date: Tue, 23 Mar 2010 15:23:50 +0100
> ksz884x: fix return value of netdev_set_eeprom
>
> netdev_set_eeprom() confused ethtool by just returning 1 on error
> instead of a proper -EINVAL.
>
> Signed-off-by: Jens Rottmann <JRottmann@LiPPERTEmbedded.de>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-23 20:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-23 14:23 [PATCH] ksz884x: fix return value of netdev_set_eeprom Jens Rottmann
2010-03-23 20:09 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.