From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753925Ab0CWT5i (ORCPT ); Tue, 23 Mar 2010 15:57:38 -0400 Received: from relay3.sgi.com ([192.48.152.1]:48541 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753325Ab0CWT5g (ORCPT ); Tue, 23 Mar 2010 15:57:36 -0400 Date: Tue, 23 Mar 2010 14:57:28 -0500 From: Robin Holt To: Anton Starikov Cc: Robin Holt , Andrew Morton , Ingo Molnar , Linus Torvalds , linux-mm@kvack.org, linux-kernel@vger.kernel.org, bugzilla-daemon@bugzilla.kernel.org, bugme-daemon@bugzilla.kernel.org, Peter Zijlstra Subject: Re: [Bugme-new] [Bug 15618] New: 2.6.18->2.6.32->2.6.33 huge regression in performance Message-ID: <20100323195728.GC6169@sgi.com> References: <20100323102208.512c16cc.akpm@linux-foundation.org> <20100323173409.GA24845@elte.hu> <20100323180002.GA2965@elte.hu> <15090451-C292-44D6-B2BA-DCBCBEEF429D@gmail.com> <20100323112141.7f248f2b.akpm@linux-foundation.org> <41DAB29F-59B7-4D38-A389-75FAC47225BF@gmail.com> <20100323192213.GA6169@sgi.com> <20100323194959.GB6169@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100323194959.GB6169@sgi.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 23, 2010 at 02:49:59PM -0500, Robin Holt wrote: > On Tue, Mar 23, 2010 at 08:30:19PM +0100, Anton Starikov wrote: > > > > On Mar 23, 2010, at 8:22 PM, Robin Holt wrote: > > > > > On Tue, Mar 23, 2010 at 07:25:43PM +0100, Anton Starikov wrote: > > >> On Mar 23, 2010, at 7:21 PM, Andrew Morton wrote: > > >>>> I will apply this commits to 2.6.32, I afraid current OFED (which I need also) will not work on 2.6.33+. > > >>>> > > >>> > > >>> You should be able to simply set CONFIG_RWSEM_GENERIC_SPINLOCK=n, > > >>> CONFIG_RWSEM_XCHGADD_ALGORITHM=y by hand, as I mentioned earlier? > > >> > > >> Hm. I tried, but when I do "make oldconfig", then it gets rewritten, so I assume that it conflicts with some other setting from default fedora kernel config. trying to figure out which one exactly. > > > > > > Have you tracked this down yet? I just got the patches applied against > > > an older kernel and am running into the same issue. > > > > I decided to not track down this issue and just applied patches. I understood that with this patches there is no need to change this config options. Am I wrong? > > We might need to also apply: > bafaecd11df15ad5b1e598adc7736afcd38ee13d For the record, these are the patches I have applied to a 2.6.32 kernel from a vendor: 59c33fa7791e9948ba467c2b83e307a0d087ab49 5d0b7235d83eefdafda300656e97d368afcafc9a 1838ef1d782f7527e6defe87e180598622d2d071 0d1622d7f526311d87d7da2ee7dd14b73e45d3fc bafaecd11df15ad5b1e598adc7736afcd38ee13d A quick look at the disassembly makes it look like we are using the rwsem_64, et al. Robin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 7F6466B01CC for ; Tue, 23 Mar 2010 15:57:37 -0400 (EDT) Date: Tue, 23 Mar 2010 14:57:28 -0500 From: Robin Holt Subject: Re: [Bugme-new] [Bug 15618] New: 2.6.18->2.6.32->2.6.33 huge regression in performance Message-ID: <20100323195728.GC6169@sgi.com> References: <20100323102208.512c16cc.akpm@linux-foundation.org> <20100323173409.GA24845@elte.hu> <20100323180002.GA2965@elte.hu> <15090451-C292-44D6-B2BA-DCBCBEEF429D@gmail.com> <20100323112141.7f248f2b.akpm@linux-foundation.org> <41DAB29F-59B7-4D38-A389-75FAC47225BF@gmail.com> <20100323192213.GA6169@sgi.com> <20100323194959.GB6169@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100323194959.GB6169@sgi.com> Sender: owner-linux-mm@kvack.org To: Anton Starikov Cc: Robin Holt , Andrew Morton , Ingo Molnar , Linus Torvalds , linux-mm@kvack.org, linux-kernel@vger.kernel.org, bugzilla-daemon@bugzilla.kernel.org, bugme-daemon@bugzilla.kernel.org, Peter Zijlstra List-ID: On Tue, Mar 23, 2010 at 02:49:59PM -0500, Robin Holt wrote: > On Tue, Mar 23, 2010 at 08:30:19PM +0100, Anton Starikov wrote: > > > > On Mar 23, 2010, at 8:22 PM, Robin Holt wrote: > > > > > On Tue, Mar 23, 2010 at 07:25:43PM +0100, Anton Starikov wrote: > > >> On Mar 23, 2010, at 7:21 PM, Andrew Morton wrote: > > >>>> I will apply this commits to 2.6.32, I afraid current OFED (which I need also) will not work on 2.6.33+. > > >>>> > > >>> > > >>> You should be able to simply set CONFIG_RWSEM_GENERIC_SPINLOCK=n, > > >>> CONFIG_RWSEM_XCHGADD_ALGORITHM=y by hand, as I mentioned earlier? > > >> > > >> Hm. I tried, but when I do "make oldconfig", then it gets rewritten, so I assume that it conflicts with some other setting from default fedora kernel config. trying to figure out which one exactly. > > > > > > Have you tracked this down yet? I just got the patches applied against > > > an older kernel and am running into the same issue. > > > > I decided to not track down this issue and just applied patches. I understood that with this patches there is no need to change this config options. Am I wrong? > > We might need to also apply: > bafaecd11df15ad5b1e598adc7736afcd38ee13d For the record, these are the patches I have applied to a 2.6.32 kernel from a vendor: 59c33fa7791e9948ba467c2b83e307a0d087ab49 5d0b7235d83eefdafda300656e97d368afcafc9a 1838ef1d782f7527e6defe87e180598622d2d071 0d1622d7f526311d87d7da2ee7dd14b73e45d3fc bafaecd11df15ad5b1e598adc7736afcd38ee13d A quick look at the disassembly makes it look like we are using the rwsem_64, et al. Robin -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org