From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751986Ab0CYD2p (ORCPT ); Wed, 24 Mar 2010 23:28:45 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:40902 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751875Ab0CYD2n (ORCPT ); Wed, 24 Mar 2010 23:28:43 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: Mel Gorman Subject: Re: [PATCH 04/11] Allow CONFIG_MIGRATION to be set without CONFIG_NUMA or memory hot-remove Cc: kosaki.motohiro@jp.fujitsu.com, Christoph Lameter , Andrew Morton , Andrea Arcangeli , Adam Litke , Avi Kivity , David Rientjes , Rik van Riel , linux-kernel@vger.kernel.org, linux-mm@kvack.org In-Reply-To: <20100319101651.GT12388@csn.ul.ie> References: <20100319152106.8775.A69D9226@jp.fujitsu.com> <20100319101651.GT12388@csn.ul.ie> Message-Id: <20100325095918.9454.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Thu, 25 Mar 2010 12:28:40 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Fri, Mar 19, 2010 at 03:21:20PM +0900, KOSAKI Motohiro wrote: > > > On Thu, Mar 18, 2010 at 08:56:23AM +0900, KOSAKI Motohiro wrote: > > > > > On Wed, 17 Mar 2010, Mel Gorman wrote: > > > > > > > > > > > > If select MIGRATION works, we can remove "depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE" > > > > > > > line from config MIGRATION. > > > > > > > > > > > > > > > > > > > I'm not quite getting why this would be an advantage. COMPACTION > > > > > > requires MIGRATION but conceivable both NUMA and HOTREMOVE can work > > > > > > without it. > > > > > > > > > > Avoids having to add additional CONFIG_XXX on the page migration "depends" > > > > > line in the future. > > > > > > > > Yes, Kconfig mess freqently shot ourself in past days. if we have a chance > > > > to remove unnecessary dependency, we should do. that's my intention of the last mail. > > > > > > > > > > But if the depends line is removed, it could be set without NUMA, memory > > > hot-remove or compaction enabled. That wouldn't be very useful. I'm > > > missing something obvious. > > > > Perhaps I'm missing something. > > > > my point is, force enabling useless config is not good idea (yes, i agree). but config > > selectability doesn't cause any failure. IOW, usefulness and dependency aren't > > related so much. personally I dislike _unnecessary_ dependency. > > > > If my opinion cause any bad thing, I'll withdraw it. of course. > > > > I've changed the MIGRATION entry to > > config MIGRATION > bool "Page migration" > def_bool y > depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE > > i.e. it no longer depends on COMPACTION because the "select MIGRATION" > in that line is enough. > > I've left NUMA and HOTREMOVE because migration is an optional feature > for those configurations. ok... I don't oppose it anymore. Let's dive into Kconfig select hell ;) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id 177806B0071 for ; Wed, 24 Mar 2010 23:28:44 -0400 (EDT) Received: from m1.gw.fujitsu.co.jp ([10.0.50.71]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o2P3SgxW003591 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Thu, 25 Mar 2010 12:28:42 +0900 Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 3D86845DE55 for ; Thu, 25 Mar 2010 12:28:42 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 17D7F45DE52 for ; Thu, 25 Mar 2010 12:28:42 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id F0684E3800B for ; Thu, 25 Mar 2010 12:28:41 +0900 (JST) Received: from m106.s.css.fujitsu.com (m106.s.css.fujitsu.com [10.249.87.106]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 901D5E38006 for ; Thu, 25 Mar 2010 12:28:41 +0900 (JST) From: KOSAKI Motohiro Subject: Re: [PATCH 04/11] Allow CONFIG_MIGRATION to be set without CONFIG_NUMA or memory hot-remove In-Reply-To: <20100319101651.GT12388@csn.ul.ie> References: <20100319152106.8775.A69D9226@jp.fujitsu.com> <20100319101651.GT12388@csn.ul.ie> Message-Id: <20100325095918.9454.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Thu, 25 Mar 2010 12:28:40 +0900 (JST) Sender: owner-linux-mm@kvack.org To: Mel Gorman Cc: kosaki.motohiro@jp.fujitsu.com, Christoph Lameter , Andrew Morton , Andrea Arcangeli , Adam Litke , Avi Kivity , David Rientjes , Rik van Riel , linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: > On Fri, Mar 19, 2010 at 03:21:20PM +0900, KOSAKI Motohiro wrote: > > > On Thu, Mar 18, 2010 at 08:56:23AM +0900, KOSAKI Motohiro wrote: > > > > > On Wed, 17 Mar 2010, Mel Gorman wrote: > > > > > > > > > > > > If select MIGRATION works, we can remove "depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE" > > > > > > > line from config MIGRATION. > > > > > > > > > > > > > > > > > > > I'm not quite getting why this would be an advantage. COMPACTION > > > > > > requires MIGRATION but conceivable both NUMA and HOTREMOVE can work > > > > > > without it. > > > > > > > > > > Avoids having to add additional CONFIG_XXX on the page migration "depends" > > > > > line in the future. > > > > > > > > Yes, Kconfig mess freqently shot ourself in past days. if we have a chance > > > > to remove unnecessary dependency, we should do. that's my intention of the last mail. > > > > > > > > > > But if the depends line is removed, it could be set without NUMA, memory > > > hot-remove or compaction enabled. That wouldn't be very useful. I'm > > > missing something obvious. > > > > Perhaps I'm missing something. > > > > my point is, force enabling useless config is not good idea (yes, i agree). but config > > selectability doesn't cause any failure. IOW, usefulness and dependency aren't > > related so much. personally I dislike _unnecessary_ dependency. > > > > If my opinion cause any bad thing, I'll withdraw it. of course. > > > > I've changed the MIGRATION entry to > > config MIGRATION > bool "Page migration" > def_bool y > depends on NUMA || ARCH_ENABLE_MEMORY_HOTREMOVE > > i.e. it no longer depends on COMPACTION because the "select MIGRATION" > in that line is enough. > > I've left NUMA and HOTREMOVE because migration is an optional feature > for those configurations. ok... I don't oppose it anymore. Let's dive into Kconfig select hell ;) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org