From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752766Ab0CZJam (ORCPT ); Fri, 26 Mar 2010 05:30:42 -0400 Received: from legolas.restena.lu ([158.64.1.34]:45089 "EHLO legolas.restena.lu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754Ab0CZJaj convert rfc822-to-8bit (ORCPT ); Fri, 26 Mar 2010 05:30:39 -0400 Date: Fri, 26 Mar 2010 10:29:51 +0100 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= To: Dmitry Torokhov Cc: Jiri Kosina , linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Rick L. Vinyard Jr." , Nicu Pavel , Oliver Neukum , Jaya Kumar Subject: Re: [PATCH v3 1/6] hid: new driver for PicoLCD device Message-ID: <20100326102951.3b9ecda1@neptune.home> In-Reply-To: <20100326065656.GC26602@core.coreip.homeip.net> References: <20100324233707.7243b04d@neptune.home> <20100324234022.0361bd80@neptune.home> <20100326065656.GC26602@core.coreip.homeip.net> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.18.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 March 2010 Dmitry Torokhov wrote: > On Wed, Mar 24, 2010 at 11:40:22PM +0100, Bruno Prémont wrote: > > + for (i = 0; i < PICOLCD_KEYS; i++) { > > + int key = ((int *)idev->keycode)[i]; > > Keycodes are now short, not int. Also, just do: > > input_set_capability(idev, EV_KEY, data->keycode[i]); > > > + if (key < KEY_MAX && key >= 0) > > + input_set_capability(idev, EV_KEY, key); Oops, I was not careful enough when switching over... Thanks for catching, Bruno From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= Subject: Re: [PATCH v3 1/6] hid: new driver for PicoLCD device Date: Fri, 26 Mar 2010 10:29:51 +0100 Message-ID: <20100326102951.3b9ecda1@neptune.home> References: <20100324233707.7243b04d@neptune.home> <20100324234022.0361bd80@neptune.home> <20100326065656.GC26602@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from legolas.restena.lu ([158.64.1.34]:45089 "EHLO legolas.restena.lu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754Ab0CZJaj convert rfc822-to-8bit (ORCPT ); Fri, 26 Mar 2010 05:30:39 -0400 In-Reply-To: <20100326065656.GC26602@core.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Jiri Kosina , linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Rick L. Vinyard Jr." , Nicu Pavel , Oliver Neukum , Jaya Kumar On Thu, 25 March 2010 Dmitry Torokhov wrote= : > On Wed, Mar 24, 2010 at 11:40:22PM +0100, Bruno Pr=C3=A9mont wrote: > > + for (i =3D 0; i < PICOLCD_KEYS; i++) { > > + int key =3D ((int *)idev->keycode)[i]; >=20 > Keycodes are now short, not int. Also, just do: >=20 > input_set_capability(idev, EV_KEY, data->keycode[i]); >=20 > > + if (key < KEY_MAX && key >=3D 0) > > + input_set_capability(idev, EV_KEY, key); Oops, I was not careful enough when switching over... Thanks for catching, Bruno -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= Date: Fri, 26 Mar 2010 09:29:51 +0000 Subject: Re: [PATCH v3 1/6] hid: new driver for PicoLCD device Message-Id: <20100326102951.3b9ecda1@neptune.home> List-Id: References: <20100324233707.7243b04d@neptune.home> <20100324234022.0361bd80@neptune.home> <20100326065656.GC26602@core.coreip.homeip.net> In-Reply-To: <20100326065656.GC26602@core.coreip.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Dmitry Torokhov Cc: Jiri Kosina , linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Rick L. Vinyard Jr." , Nicu Pavel , Oliver Neukum , Jaya Kumar On Thu, 25 March 2010 Dmitry Torokhov wrote: > On Wed, Mar 24, 2010 at 11:40:22PM +0100, Bruno Pr=C3=A9mont wrote: > > + for (i =3D 0; i < PICOLCD_KEYS; i++) { > > + int key =3D ((int *)idev->keycode)[i]; >=20 > Keycodes are now short, not int. Also, just do: >=20 > input_set_capability(idev, EV_KEY, data->keycode[i]); >=20 > > + if (key < KEY_MAX && key >=3D 0) > > + input_set_capability(idev, EV_KEY, key); Oops, I was not careful enough when switching over... Thanks for catching, Bruno