All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Subject: removing set_clientdata(NULL)
Date: Sat, 27 Mar 2010 13:15:58 +0100	[thread overview]
Message-ID: <20100327121558.GA5880@pengutronix.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 1079 bytes --]

Hi Jean,

do you have already something in mind how to proceed with the
i2c_setclientdata-topic? I could offer the following:

I modify my semantic patch to remove all set_clientdata(NULL) calls connected
to a kfree(). Then, we could have a look if there are still some left and
investigate why. Once all issues are resolved (maybe there are none), we should
know what to add in the core-layer, hopefully just the call to set_clientdata.

Regarding this comment:

> the core should just set the client data to NULL. If there are drivers that
> rely on the current behavior, then those drivers should be reviewed first as
> to the reason why they need it.

I could check if there is any probe-function calling get_clientdata and making
use of that? That is probably the most obvious thing which would need to rely
on the current behaviour or did I miss something?

Have a nice weekend,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

             reply	other threads:[~2010-03-27 12:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-27 12:15 Wolfram Sang [this message]
     [not found] ` <20100327121558.GA5880-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-03-29 14:28   ` removing set_clientdata(NULL) Jean Delvare
     [not found]     ` <20100329162812.548d131b-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-03-29 15:09       ` Wolfram Sang
     [not found]         ` <20100329150956.GB6717-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-03-29 15:27           ` Jean Delvare
     [not found]             ` <20100329172734.7cd7341d-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-03-29 15:49               ` Mark Brown
     [not found]                 ` <20100329154910.GE13239-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2010-03-29 16:43                   ` Jean Delvare
2010-03-30  2:48               ` Wolfram Sang
     [not found]                 ` <20100330024831.GB23862-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-03-30  7:05                   ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100327121558.GA5880@pengutronix.de \
    --to=w.sang-bicnvbalz9megne8c9+irq@public.gmane.org \
    --cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.