From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752918Ab0C2Sht (ORCPT ); Mon, 29 Mar 2010 14:37:49 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:41383 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751512Ab0C2Shs (ORCPT ); Mon, 29 Mar 2010 14:37:48 -0400 Date: Mon, 29 Mar 2010 19:39:33 +0100 From: Alan Cox To: "H. Peter Anvin" Cc: Giel van Schijndel , Jesse Barnes , Hans de Goede , Jean Delvare , Jonathan Cameron , Andrew Morton , Bjorn Helgaas , Dominik Brodowski , Laurens Leemans , lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] resource: shared I/O region support Message-ID: <20100329193933.1a04762b@lxorguk.ukuu.org.uk> In-Reply-To: <4BB0E73F.2080104@zytor.com> References: <20100325125005.6d58cfaf@lxorguk.ukuu.org.uk> <1269523063-30346-1-git-send-email-me@mortis.eu> <20100325155705.1ec79dbc@lxorguk.ukuu.org.uk> <20100325180347.GA2761@salidar.me.mortis.eu> <20100325181633.0313b8a5@lxorguk.ukuu.org.uk> <20100329081834.GB27956@salidar.me.mortis.eu> <20100329090713.1317942b@jbarnes-piketon> <20100329173800.GA3583@salidar.me.mortis.eu> <4BB0E73F.2080104@zytor.com> X-Mailer: Claws Mail 3.7.4 (GTK+ 2.18.6; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > What I *really* object to with this patch is that it inherently assumes > that there is only one multiplexed resource in the entire system... but > of course nowhere enforces that. The patch does nothing of the sort. Not unless there is a bug I am not seeing anyway. It does assume nobody tries to grab pairs of such resources as it doesn't do deadlock avoidance. It's now a shared resource patch however, its a multiplexor patch and that is precisely why it is called MUX not SHARED or OVERLAY Alan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Date: Mon, 29 Mar 2010 18:39:33 +0000 Subject: Re: [lm-sensors] [PATCH 1/3] resource: shared I/O region support Message-Id: <20100329193933.1a04762b@lxorguk.ukuu.org.uk> List-Id: References: <20100325125005.6d58cfaf@lxorguk.ukuu.org.uk> <1269523063-30346-1-git-send-email-me@mortis.eu> <20100325155705.1ec79dbc@lxorguk.ukuu.org.uk> <20100325180347.GA2761@salidar.me.mortis.eu> <20100325181633.0313b8a5@lxorguk.ukuu.org.uk> <20100329081834.GB27956@salidar.me.mortis.eu> <20100329090713.1317942b@jbarnes-piketon> <20100329173800.GA3583@salidar.me.mortis.eu> <4BB0E73F.2080104@zytor.com> In-Reply-To: <4BB0E73F.2080104@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "H. Peter Anvin" Cc: Giel van Schijndel , Jesse Barnes , Hans de Goede , Jean Delvare , Jonathan Cameron , Andrew Morton , Bjorn Helgaas , Dominik Brodowski , Laurens Leemans , lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org > What I *really* object to with this patch is that it inherently assumes > that there is only one multiplexed resource in the entire system... but > of course nowhere enforces that. The patch does nothing of the sort. Not unless there is a bug I am not seeing anyway. It does assume nobody tries to grab pairs of such resources as it doesn't do deadlock avoidance. It's now a shared resource patch however, its a multiplexor patch and that is precisely why it is called MUX not SHARED or OVERLAY Alan _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors